Conversation
blegat
marked this pull request as draft
April 8, 2026 20:11
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 99.86% 98.65% -1.21%
==========================================
Files 2 2
Lines 756 820 +64
==========================================
+ Hits 755 809 +54
- Misses 1 11 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
odow
reviewed
May 1, 2026
| using Pkg | ||
| Pkg.add([ | ||
| PackageSpec(name="MathOptInterface", rev="bl/nonlinear_model"), | ||
| ]) |
Member
There was a problem hiding this comment.
Add [sources] section to Project.toml instead
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
It doesn't work on Julia v1.10: https://pkgdocs.julialang.org/v1.10/toml-files/#The-%5Bsources%5D-section
Member
There was a problem hiding this comment.
Oh. Well at minimum, it'll work for the newer versions. Just exclude 1.10 during testing.
The nonlinear model is now built with MOI.Nonlinear.model(ad_backend), which ArrayDiff overrides for ArrayDiff.Mode, so the ArrayDiff dependency is removed. The default backend receives MOI's layered model; the ObjectiveFunctionType query goes through a _has_nlp_objective helper that understands the layers, plain models, and custom AD models. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6 tasks
`MOI.Nonlinear.model`, `ModelWithQuad` and `ModelWithOracles` only exist on MathOptInterface#bl/linearity, so the extension failed to load against a released MathOptInterface, which is what ArrayDiff's CI resolves. The two layered-model methods of `_has_nlp_objective` are now only defined when `ModelWithQuad` exists, and `_init_nlp_model` goes through `_nonlinear_model`, which uses `MOI.Nonlinear.model` when available and otherwise asks the backend's own package for `model`, as ArrayDiff defines `ArrayDiff.model(::ArrayDiff.Mode)`. MOI's own backends keep using `MOI.Nonlinear.Model`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for blegat/ArrayDiff.jl#39
Requires