Heroku deploy temporarily broken

[michielbdejong]

if you want to deploy to Heroku now, use this link: https://dashboard.heroku.com/new?button-url=https%3A%2F%2Fgithub.com%2Finterledgerjs%2Filp-kit&template=https%3A%2F%2Fgithub.com%2Finterledgerjs%2Filp-kit%2Ftree%2Fmaster (notice 'master' instead of 'release' at the end of that URL). It will be fixed again when we tag the next release.

[KattMingMing]

@michielbdejong - Using master doesn't actually solve the problem, I think it worked at the time of your message, but once you made the next commit (87c6381c9752503b70333acefd9d6018579aa635) app.json was removed. To fix the deployment to heroku problem the solution looks like either deprecating Heroku support and pointing the readme to this commit ac9ad4936abd1b244974f9101c74624c00d2fe37 instead of master since heroku depends on a manifest file app.json which was removed or adding back an app.json so that it tracks the current state of the project. Happy to add it for you as long as it's something you guys wish to keep supporting.

[michielbdejong]

we do, yes! Although the architecture of the master branch changed considerably and probably we should also fix what npm start does? cc @vhpoet

[KattMingMing]

It definitely looks like there's been some changes. @michielbdejong any thoughts on using yarn instead of npm? Also I'm not sure of the place to leave this, but would you be open to somebody migrating the project from js to typescript? :)

[michielbdejong]

we did switch to yarn at some point, actually! :) But npm 5 also has a build cache, and there will always be people who want to use npm, so then we switched back to npm.

There is a tiny portion of the project already in typescript, namely https://github.com/interledgerjs/ilp-packet. l think there's a lot more other things that could be contributed, which would be higher priority, for instance, we want to switch from using JSON over HTTP to OER over WebSockets, that work is going on in https://github.com/interledgerjs/ilp-plugin-payment-channel-framework/issues - would you be interested in playing a part in those efforts?