A way to enable for Github Enterprise URL?

[michael-iglesias]

Hey,

Is there an easy way to have git-splainin icon to display for a Github Enterprise URL?

[warbrett]

Hey Michael,

I've never used github enterprise but providing the PR page is the same it shouldn't take more than adding the url format to the matches array located here:

git-splainin/manifest.json

Line 34 in b4d6cbe

"matches": ["https://github.com/*"],

Alternatively since this was released github has implemented its own PR template functionality which may be simpler in your case. You can read more about using that here: https://github.com/blog/2111-issue-and-pull-request-templates

[warbrett]

Actually, I take that first part back. Sorry it's been a while since I've touched this project there are actually a couple places where we look at the url:

git-splainin/src/background.js

Line 27 in b4d6cbe

const regexUrl = /https:\/\/github\.com\/.*\/.*\/compare\/..*/;

git-splainin/src/stores/config.js

Line 37 in b4d6cbe

chrome.tabs.query({ url: 'https://github.com/*/*' }, function(tabs){

git-splainin/src/stores/template.js

Line 108 in b4d6cbe

chromeApi.tabs.query({ url: 'https://github.com/*/*' }, function(tabs){

Still doable but a little more work.

[michael-iglesias]

@warbrett Thanks for the response! I didn't know Github added templates. If that doesn't do the trick for me I'll fork and make changes in those locations. Great extension you've created here btw! I started using it last year when I stumbled upon it. Unfortunately, I joined a company that uses SVN, so I've been stuck in the stone ages for the past few months lol We are now moving to git (slowly but surely).

Cheers,
Michael