chore: pre-commit is the single git-hook entry point, bump hedron pin#183
Open
helly25 wants to merge 1 commit into
Open
chore: pre-commit is the single git-hook entry point, bump hedron pin#183helly25 wants to merge 1 commit into
helly25 wants to merge 1 commit into
Conversation
Two related cleanups from the #182 retrospective. 1) Single git-hook entry point. Today both `pre-commit install` and `trunk actions install` write to `.git/hooks/pre-commit` and `.git/hooks/pre-push` — last installer wins, silently. Devs running both end up with one tool's hook disabled at random. Move trunk's `trunk-fmt-pre-commit` and `trunk-check-pre-push` from `actions.enabled` to `actions.disabled` in .trunk/trunk.yaml, and add a single `trunk fmt` delegate as a local hook in .pre-commit-config.yaml. pre-commit owns the git hook; devs run `pre-commit install` once and trunk's formatters fire on every commit through the delegate. CI's two jobs (`pre-commit` + `trunk`) are unchanged; both still run independently. README's dev-setup paragraph updated to match. 2) Bump hedron_compile_commands pin. `bazelmod/dev.MODULE.bazel` was pinned at `6f0f6e4f` (Apr 2024). Bump to `abb61a68` (Aug 2025) which is upstream main HEAD. The two intervening commits are pre-commit autoupdate merges only — no behavior change — but the pin should not drift further. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related cleanups from the #182 retrospective.
1. Single git-hook entry point
Today both
pre-commit installandtrunk actions installwrite to.git/hooks/pre-commitand.git/hooks/pre-push— last installer wins, silently. Devs running both end up with one tool's hook disabled at random.Resolution:
trunk-fmt-pre-commitandtrunk-check-pre-pushfromactions.enabledtoactions.disabledin.trunk/trunk.yaml.trunk fmtdelegate as alocalhook in.pre-commit-config.yaml.pre-commit installonce and trunk's formatters fire on every commit through the delegate.pre-commit+trunk) are unchanged; both still run independently.README's dev-setup paragraph updated to match.
2. Bump
hedron_compile_commandspinbazelmod/dev.MODULE.bazelwas pinned at6f0f6e4f(Apr 2024). Bump toabb61a68(Aug 2025), which is current upstreammainHEAD. The two intervening commits are pre-commit autoupdate merges only — no behavior change — but the pin should not drift further.Test plan
pre-commit installonce locally;git committriggerstrunk fmtvia the new local hook without anytrunk actions installstep.🤖 Generated with Claude Code