BE-302: HashQL: Statement cost analysis for execution target placement #8339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

indietyp wants to merge 31 commits into bm/be-317-hashql-projectionextraction-for-entity-access from bm/be-302-hashql-statement-coloring-based-on-capabilities

.claude/skills/testing-hashql/references/mir-builder-guide.md

-Original file line number
+Diff line change
@@ Expand Up @@
     })
     ```
+    **Important:** Only a single `decl` statement is supported. Declare all locals in one comma-separated list:
+    ```rust
+    // ✅ Correct - single decl with all locals
+    decl env: (), vertex: Entity, x: Int, y: Int, result: Bool;
+    // ❌ Wrong - multiple decl statements will not compile
+    decl env: (), vertex: Entity;
+    decl x: Int, y: Int;
+    decl result: Bool;
+    ```
     ### Header
     | Component | Description | Example |
@@ Expand Down Expand Up @@
     | `(a: T1, b: T2)` | Struct types | `(a: Int, b: Bool)` |
     | `[List T]` | List type (intrinsic) | `[List Int]`, `[List (Int, Bool)]` |
     | `[fn(T1, T2) -> R]` | Closure types | `[fn(Int) -> Int]`, `[fn() -> Bool]` |
+    | `[Opaque path; T]` | Opaque type with symbol path | `[Opaque sym::path::Entity; ?]` |
     | `\|types\| types.custom()` | Custom type expression | `\|t\| t.null()` |
     ### Projections (Optional)
@@ Expand All @@
     @proj <name> = <base>.<field>: <type>, ...;
     ```
-    Supports nested projections:
+    **Field access modes:**
+    - Numeric index (e.g., `tup.0`) → `ProjectionKind::Field`
+    - Named field (e.g., `entity.metadata`) → `ProjectionKind::FieldByName`
+    Each `@proj` declaration supports only ONE field after the base. For deeper paths, chain through intermediate declarations:
     ```rust
     let body = body!(interner, env; fn@0/0 -> Int {
         decl tup: ((Int, Int), Int), result: Int;
-        @proj inner = tup.0: (Int, Int), inner_1 = tup.0.1: Int;
+        // inner uses tup as base, inner_1 uses inner as base
+        @proj inner = tup.0: (Int, Int), inner_1 = inner.1: Int;
         bb0() {
             result = load inner_1;
@@ Expand All / @@ -111,6 +130,22 @@ let body = body!(interner, env; fn@0/0 -> Int { @@
     });
     ```
+    Named field projections for opaque types:
+    ```rust
+    use hashql_core::symbol::sym;
+    let body = body!(interner, env; [graph::read::filter]@0/2 -> Bool {
+        decl env: (), vertex: [Opaque sym::path::Entity; ?];
+        // Chain: vertex -> metadata -> archived
+        @proj metadata = vertex.metadata: ?, archived = metadata.archived: Bool;
+        bb0() {
+            return archived;
+        }
+    });
+    ```
     ### Statements
     | Syntax | Description | MIR Equivalent |
@@ Expand Down @@

AGENTS.md

-Original file line number
+Diff line change
@@ Expand Up @@
     CRITICAL: For the files referenced below, use your Read tool to load it on a need-to-know basis, ONLY when relevant to the SPECIFIC task at hand:
-    - @.config/agents/rules/*.md
+    - .config/agents/rules/*.md
     Instructions:
@@ Expand Down @@

Cargo.toml

-Original file line number
+Diff line change
@@ Expand Up / @@ -93,7 +93,6 @@ hashql-syntax-jexpr.path = "libs/@local/hashql/syntax-jexpr" @@
     type-system.path                    = "libs/@blockprotocol/type-system/rust"
     # External dependencies
-    allocator-api2                     = { version = "0.2.8", default-features = false }
     annotate-snippets                  = { version = "0.12.8", default-features = false }
     ansi-to-html                       = { version = "0.2.2", default-features = false }
     anstream                           = { version = "0.6.21", default-features = false }
@@ Expand Down @@

libs/@local/hashql/compiletest/src/suite/mir_reify.rs

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -20,7 +20,7 @@ use hashql_mir::{
  
        context::MirContext,

        def::{DefId, DefIdSlice, DefIdVec},

        intern::Interner,

        pretty::{D2Buffer, D2Format, TextFormat},

        pretty::{D2Buffer, D2Format, TextFormatOptions},

    };

    use super::{RunContext, Suite, SuiteDiagnostic, SuiteDirectives, common::process_status};

    @@ -87,12 +87,15 @@ pub(crate) fn mir_format_text<'heap>(
  
            TypeFormatterOptions::terse().with_qualified_opaque_names(true),

        );

        let mut text_format = TextFormat {

        let mut text_format = TextFormatOptions {

            writer,

            indent: 4,

            sources: bodies,

            types,

        };

            annotations: (),

        }

        .build();

        text_format

            .format(bodies, &[root])

            .expect("should be able to write bodies");

libs/@local/hashql/core/src/heap/mod.rs

-Original file line number
+Diff line change
@@ Expand Up / @@ -256,7 +256,7 @@ impl Heap { @@
             strings.reserve(TABLES.iter().map(|table| table.len()).sum());
             for &table in TABLES {
-                for &symbol in table {
+                for symbol in table {
                     assert!(strings.insert(symbol.as_str()));
                 }
             }
@@ Expand Down @@

libs/@local/hashql/core/src/id/bit_vec/mod.rs

-Original file line number
+Diff line change
@@ Expand Up / @@ -228,6 +228,15 @@ impl<T: Id> DenseBitSet<T> { @@
             new_word != word
         }
+        #[inline]
+        pub fn set(&mut self, elem: T, value: bool) -> bool {
+            if value {
+                self.insert(elem)
+            } else {
+                self.remove(elem)
+            }
+        }
         #[inline]
         pub fn insert_range(&mut self, elems: impl RangeBounds<T>) {
             let Some((start, end)) = inclusive_start_end(elems, self.domain_size) else {
@@ Expand Down @@

libs/@local/hashql/core/src/module/std_lib/graph/types/knowledge/entity.rs

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -4,7 +4,7 @@ use crate::{
  
            StandardLibrary,

            std_lib::{self, ItemDef, ModuleDef, StandardLibraryModule, core::option::option},

        },

        symbol::Symbol,

        symbol::{Symbol, sym},

    };

    pub(in crate::module::std_lib) struct Entity {

    @@ -106,7 +106,7 @@ impl<'heap> StandardLibraryModule<'heap> for Entity {
  
            let entity_ty = lib.ty.generic(

                [t_arg],

                lib.ty.opaque(

                    "::graph::types::knowledge::entity::Entity",

                    sym::path::Entity,

                    lib.ty.r#struct([

                        ("id", entity_record_id_ty),

                        ("properties", t_param),

libs/@local/hashql/core/src/symbol/sym.rs

-Original file line number
+Diff line change
@@ Expand Up / @@ -61,67 +61,77 @@ macro_rules! symbols { @@
     }
     symbols![lexical; LEXICAL;
-        BaseUrl,
-        Boolean,
-        Dict,
-        E,
-        Err,
-        Integer,
-        Intersection,
-        List,
-        Never,
-        None,
-        Null,
-        Number,
-        Ok,
-        R,
-        Result,
-        Some,
-        String,
-        T,
-        U,
-        Union,
-        Unknown,
-        Url,
         access,
         add,
         and,
+        archived,
+        archived_by_id,
+        bar,
+        BaseUrl,
         bit_and,
         bit_not,
         bit_or,
         bit_shl,
         bit_shr,
         bit_xor,
+        Boolean,
         collect,
+        confidence,
         core,
+        created_at_decision_time,
+        created_at_transaction_time,
+        created_by_id,
+        decision_time,
+        Dict,
         div,
         draft_id,
+        E,
+        edition,
+        edition_id,
+        encodings,
         entity,
         entity_edition_id,
         entity_id,
+        entity_type_ids,
         entity_uuid,
         eq,
+        Err,
         filter,
+        foo,
         gt,
         gte,
         id,
         index,
+        inferred,
         input,
         input_exists: "$exists",
+        Integer,
+        Intersection,
         kernel,
+        left_entity_confidence,
         left_entity_id,
+        left_entity_provenance,
         link_data,
+        List,
         lt,
         lte,
         math,
+        metadata,
         mul,
         ne,
+        Never,
+        None,
         not,
+        Null,
         null,
+        Number,
+        Ok,
         option,
         or,
         pow,
         properties,
+        provenance,
+        provided,
         r#as: "as",
         r#as_force: "as!",
         r#else: "else",
@@ Expand All / @@ -136,11 +146,27 @@ symbols![lexical; LEXICAL; @@
         r#true: "true",
         r#type: "type",
         r#use: "use",
+        R,
+        record_id,
+        Result,
+        right_entity_confidence,
         right_entity_id,
+        right_entity_provenance,
+        Some,
         special_form,
+        String,
         sub,
+        T,
+        temporal_versioning,
         then: "then",
         thunk: "thunk",
+        transaction_time,
+        U,
+        Union,
+        Unknown,
+        unknown,
+        Url,
+        vectors,
         web_id,
     ];
@@ Expand Down Expand Up / @@ -202,6 +228,7 @@ symbols![path; PATHS; @@
         graph_head_entities: "::graph::head::entities",
         graph_body_filter: "::graph::body::filter",
         graph_tail_collect: "::graph::tail::collect",
+        Entity: "::graph::types::knowledge::entity::Entity"
     ];
     pub(crate) const TABLES: &[&[&Symbol<'static>]] = &[LEXICAL, DIGITS, SYMBOLS, PATHS, INTERNAL];
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BE-302: HashQL: Statement cost analysis for execution target placement #8339

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

BE-302: HashQL: Statement cost analysis for execution target placement #8339

Are you sure you want to change the base?

Uh oh!

BE-302: HashQL: Statement cost analysis for execution target placement #8339

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!