Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ rapidfuzz = { version = "0.5.0", default-features = fal
rayon = { version = "1.11.0", default-features = false }
refinery = { version = "0.8.16", default-features = false }
regex = { version = "1.11.2", default-features = false, features = ["perf", "unicode"] }
reqwest = { version = "0.12.24", default-features = false, features = ["rustls-tls"] }
reqwest = { version = "0.13.0", default-features = false, features = ["rustls-tls"] }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reqwest 0.13 renamed the rustls-tls Cargo feature to rustls, so keeping features = ["rustls-tls"] will likely fail with an unknown-feature error when resolving/building this crate.

Fix This in Augment

πŸ€– Was this useful? React with πŸ‘ or πŸ‘Ž

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reqwest-middleware 0.4.2 (and reqwest-tracing 0.5.8) depends on reqwest ^0.12, and the codebase constructs ClientWithMiddleware from reqwest::Client (e.g. in libs/@local/graph/type-fetcher), so bumping reqwest to 0.13 here is likely to create an incompatible dual-reqwest version situation / type mismatch.

Fix This in Augment

πŸ€– Was this useful? React with πŸ‘ or πŸ‘Ž

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version bump also needs a corresponding Cargo.lock update; CI runs cargo update --workspace --locked (see .github/workflows/lint.yml), which will fail if the lockfile isn’t already consistent with the new reqwest version.

Fix This in Augment

πŸ€– Was this useful? React with πŸ‘ or πŸ‘Ž

reqwest-middleware = { version = "0.4.2", default-features = false }
reqwest-tracing = { version = "0.5.8", default-features = false }
roaring = { version = "0.11.2", default-features = false }
Expand Down
Loading