Portability to linux

[rickmark]

Today compiles clean without warning on macOS, but needs to be size portable to linux

[ChazyTheBest]

Would you mind documenting it a bit? Or just how to use it in the readme file.

It's missing ax_pthread.m4 but it compiles fine under linux, just a bunch of warnings:

$ make
make  all-recursive
make[1]: Entering directory '/home/chazy/ipadbackup/libibackup'
Making all in src
make[2]: Entering directory '/home/chazy/ipadbackup/libibackup/src'
  CC       libibackup.lo
libibackup.c:18:9: warning: no previous declaration for ‘libibackup_manifest_query_count’ [-Wmissing-declarations]
   18 | int64_t libibackup_manifest_query_count(sqlite3* database, const char* query, const char* parameter) {
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libibackup.c: In function ‘libibackup_manifest_query_count’:
libibackup.c:36:31: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=]
   36 |         printf("Read count %llu\n", count);
      |                            ~~~^     ~~~~~
      |                               |     |
      |                               |     uint64_t {aka long unsigned int}
      |                               long long unsigned int
      |                            %lu
libibackup.c: At top level:
libibackup.c:46:7: warning: no previous declaration for ‘libibackup_ensure_directory’ [-Wmissing-declarations]
   46 | char* libibackup_ensure_directory(const char* path) {
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
libibackup.c:77:9: warning: no previous declaration for ‘libibackup_load_plist’ [-Wmissing-declarations]
   77 | plist_t libibackup_load_plist(const char* directory, const char* file) {
      |         ^~~~~~~~~~~~~~~~~~~~~
libibackup.c:99:6: warning: no previous declaration for ‘libibackup_preflight_test_file’ [-Wmissing-declarations]
   99 | bool libibackup_preflight_test_file(const char* directory, const char* file) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libibackup.c:167:27: warning: no previous declaration for ‘libibackup_add_file’ [-Wmissing-declarations]
  167 | EXPORT libibackup_error_t libibackup_add_file(libibackup_client_t client, char* domain, char* relative_path, void* data, size_t length) {
      |                           ^~~~~~~~~~~~~~~~~~~
libibackup.c: In function ‘libibackup_get_domain_metrics’:
libibackup.c:298:9: warning: switch missing default case [-Wswitch-default]
  298 |         switch (sqlite3_column_int(metrics_query, 1)) {
      |         ^~~~~~
libibackup.c: In function ‘libibackup_get_file_by_id’:
libibackup.c:130:5: warning: ‘strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
  130 |     strncpy(file_component + 3, file_id, strlen(file_id));
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  CC       sha.lo
  CCLD     libibackup-1.0.la
make[2]: Leaving directory '/home/chazy/ipadbackup/libibackup/src'
Making all in include
make[2]: Entering directory '/home/chazy/ipadbackup/libibackup/include'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/chazy/ipadbackup/libibackup/include'
Making all in tools
make[2]: Entering directory '/home/chazy/ipadbackup/libibackup/tools'
  CC       ibackup_list-ibackup_list.o
ibackup_list.c:15:13: warning: no previous declaration for ‘file_type_string_for_type’ [-Wmissing-declarations]
   15 | const char* file_type_string_for_type(uint32_t type) {
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~
ibackup_list.c: In function ‘file_type_string_for_type’:
ibackup_list.c:16:5: warning: switch missing default case [-Wswitch-default]
   16 |     switch (type) {
      |     ^~~~~~
ibackup_list.c: At top level:
ibackup_list.c:27:6: warning: no previous declaration for ‘get_file_path’ [-Wmissing-declarations]
   27 | void get_file_path(libibackup_client_t client, char* file_id) {
      |      ^~~~~~~~~~~~~
ibackup_list.c:35:6: warning: no previous declaration for ‘list_domains’ [-Wmissing-declarations]
   35 | void list_domains(libibackup_client_t client, bool empty) {
      |      ^~~~~~~~~~~~
ibackup_list.c:56:6: warning: no previous declaration for ‘list_files’ [-Wmissing-declarations]
   56 | void list_files(libibackup_client_t client, char* domain) {
      |      ^~~~~~~~~~
ibackup_list.c: In function ‘list_files’:
ibackup_list.c:69:46: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=]
   69 |                 printf("%s: [%s] %s (size %llu)\n", file_list[index]->file_id, file_type_string_for_type(file_list[index]->type),
      |                                           ~~~^
      |                                              |
      |                                              long long unsigned int
      |                                           %lu
   70 |                        file_list[index]->relative_path, metadata.size);
      |                                                         ~~~~~~~~~~~~~
      |                                                                 |
      |                                                                 uint64_t {aka long unsigned int}
ibackup_list.c:67:9: warning: switch missing default case [-Wswitch-default]
   67 |         switch (file_list[index]->type) {
      |         ^~~~~~
ibackup_list.c: At top level:
ibackup_list.c:88:6: warning: no previous declaration for ‘remove_file’ [-Wmissing-declarations]
   88 | void remove_file(libibackup_client_t client, char* file_id) {
      |      ^~~~~~~~~~~
ibackup_list.c:92:6: warning: no previous declaration for ‘get_file_metadata’ [-Wmissing-declarations]
   92 | void get_file_metadata(libibackup_client_t client, char* file_id) {
      |      ^~~~~~~~~~~~~~~~~
ibackup_list.c:103:6: warning: no previous declaration for ‘check_files’ [-Wmissing-declarations]
  103 | void check_files(libibackup_client_t client) {
      |      ^~~~~~~~~~~
ibackup_list.c: In function ‘check_files’:
ibackup_list.c:128:28: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 2 has type ‘int64_t’ {aka ‘long int’} [-Wformat=]
  128 |         printf("Scanned %lld files in domain %s\n", file_index, domain_list[domain_index]);
      |                         ~~~^                        ~~~~~~~~~~
      |                            |                        |
      |                            long long int            int64_t {aka long int}
      |                         %ld
ibackup_list.c: At top level:
ibackup_list.c:139:6: warning: no previous declaration for ‘list_all_files’ [-Wmissing-declarations]
  139 | void list_all_files(libibackup_client_t client) {
      |      ^~~~~~~~~~~~~~
ibackup_list.c: In function ‘list_all_files’:
ibackup_list.c:158:50: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=]
  158 |                     printf("%s: [%s] %s (size %llu)\n", file_list[file_index]->file_id, file_type_string_for_type(file_list[file_index]->type),
      |                                               ~~~^
      |                                                  |
      |                                                  long long unsigned int
      |                                               %lu
  159 |                            file_list[file_index]->relative_path, metadata.size);
      |                                                                  ~~~~~~~~~~~~~
      |                                                                          |
      |                                                                          uint64_t {aka long unsigned int}
ibackup_list.c:156:13: warning: switch missing default case [-Wswitch-default]
  156 |             switch (file_list[file_index]->type) {
      |             ^~~~~~
ibackup_list.c: At top level:
ibackup_list.c:183:6: warning: no previous declaration for ‘get_file’ [-Wmissing-declarations]
  183 | void get_file(libibackup_client_t client, char* file_id) {
      |      ^~~~~~~~
ibackup_list.c: In function ‘get_file’:
ibackup_list.c:196:36: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 2 has type ‘__off_t’ {aka ‘long int’} [-Wformat=]
  196 |     printf("Read file with size %lld\n", path_stat.st_size);
      |                                 ~~~^     ~~~~~~~~~~~~~~~~~
      |                                    |              |
      |                                    long long int  __off_t {aka long int}
      |                                 %ld
  CCLD     ibackup_list
  CC       ibackup_extract-ibackup_extract.o
  CCLD     ibackup_extract
make[2]: Leaving directory '/home/chazy/ipadbackup/libibackup/tools'
Making all in docs
make[2]: Entering directory '/home/chazy/ipadbackup/libibackup/docs'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/chazy/ipadbackup/libibackup/docs'
make[2]: Entering directory '/home/chazy/ipadbackup/libibackup'
make[2]: Leaving directory '/home/chazy/ipadbackup/libibackup'
make[1]: Leaving directory '/home/chazy/ipadbackup/libibackup'

[rickmark]

Yeah - I can work on some quick docs

The warnings are for sure because i developed this on darwin and didn't worry too much about portability to start