fix(extensions): preserve command registry when skills fail

Author: PascalThuet

src/specify_cli/extensions.py

@@ -1703,11 +1703,31 @@ def register_enabled_extensions_for_agent(self, agent_name: str) -> None:
                     if new_registered != registered_commands:
                         updates["registered_commands"] = new_registered
 
-                registered_skills = self._register_extension_skills(manifest, ext_dir)
-                if registered_skills:
-                    existing_skills = self._valid_name_list(metadata.get("registered_skills", []))
-                    merged_skills = list(dict.fromkeys(existing_skills + registered_skills))
-                    updates["registered_skills"] = merged_skills
+                try:
+                    registered_skills = self._register_extension_skills(manifest, ext_dir)
+                except Exception as skills_err:
+                    # Skills are a companion artifact.  If command registration
+                    # already succeeded, still persist it so later cleanup can
+                    # find those command files.
+                    from . import _print_cli_warning
+
+                    _print_cli_warning(
+                        "register extension skills for",
+                        "extension",
+                        ext_id,
+                        skills_err,
+                        continuing=(
+                            "Continuing with command registration for this "
+                            "extension and the remaining extensions."
+                        ),
+                    )
+                else:
+                    if registered_skills:
+                        existing_skills = self._valid_name_list(
+                            metadata.get("registered_skills", [])
+                        )
+                        merged_skills = list(dict.fromkeys(existing_skills + registered_skills))
+                        updates["registered_skills"] = merged_skills
 
                 if updates:
                     self.registry.update(ext_id, updates)

tests/test_extension_skills.py

@@ -1028,6 +1028,45 @@ def flaky(self, agent_name, manifest, ext_dir, project_root, link_outputs=False)
         fail_meta = manager.registry.get("aaa-fail")
         assert "claude" not in fail_meta.get("registered_commands", {})
 
+    def test_skill_registration_failure_preserves_registered_commands(
+        self, project_dir, temp_dir, monkeypatch, capsys
+    ):
+        """Persist successful command registration even if skills fail.
+
+        If command files are written but skill generation raises, the command
+        registry must still be updated so later unregister/cleanup can find the
+        command files.
+        """
+        _create_init_options(project_dir, ai="claude", ai_skills=False)
+        manager = ExtensionManager(project_dir)
+        manager.install_from_directory(
+            _create_extension_dir(temp_dir, ext_id="skill-fail"), "0.1.0",
+            register_commands=False,
+        )
+
+        def fail_skills(self, manifest, ext_dir, link_outputs=False):
+            raise OSError("simulated skill directory failure")
+
+        monkeypatch.setattr(
+            ExtensionManager, "_register_extension_skills", fail_skills
+        )
+
+        manager.register_enabled_extensions_for_agent("claude")
+
+        metadata = manager.registry.get("skill-fail")
+        assert metadata is not None
+        assert metadata["registered_commands"] == {
+            "claude": [
+                "speckit.skill-fail.hello",
+                "speckit.skill-fail.world",
+            ]
+        }
+        assert metadata["registered_skills"] == []
+
+        captured = capsys.readouterr()
+        assert "register extension skills for extension 'skill-fail'" in captured.out
+        assert "Continuing with command registration" in captured.out
+
     def test_existing_agent_command_path_file_is_not_detected(
         self, project_dir, temp_dir
     ):