-
Notifications
You must be signed in to change notification settings - Fork 65.5k
Make example keyset pagination header parsing consistent #41890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an inconsistency in the keyset pagination example code where the regex pattern for parsing HTTP Link headers was using uppercase "Next" instead of the correct lowercase "next". According to RFC 8288 (Web Linking), relation types in Link headers are case-insensitive but conventionally lowercase. The fix ensures the regex pattern at line 130 now matches the lowercase "next" already used in the string check at line 148, making the example code consistent and following the standard convention.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@PauwelsPieter This change seems fine, so 🤞 that the CI checks decide to work. There's one that's not passing for pretty much everyone that I can ignore, but I'm getting another occasionally being weird now. |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why: Inconsistent use of uppercasing when parsing the
linkheaders in documentation.Closes: /
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: