Skip to content

Add caption-qa skill 🤖🤖🤖 - #5583

Merged
aaronpowell merged 2 commits into
github:mainfrom
markksantos:add-caption-qa-skill
Oct 27, 2026
Merged

aaronpowell merged 2 commits into
github:mainfrom
markksantos:add-caption-qa-skill

Conversation

@markksantos

@markksantos markksantos commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Adds caption-qa, a skill for checking SRT and WebVTT captions against published caption standards and fixing what fails. None of the current skills covers captions or subtitles.

Why it's more than the model's defaults: each standard sets different numbers, and models don't reliably know them or measure them consistently. The skill:

  • gives a limits table for Netflix English (adult and children's), the BBC subtitle guidelines and the DCMP Captioning Key, linked to each source page;
  • states the counting rules: characters per second, words per minute, frame-based gaps at the video's frame rate, overlaps;
  • sets a fix order that retimes before it rewords, so captions stay verbatim.

It also includes a short, self-contained Python check that applies those limits and exits with 1 on failure, for CI. No external tools or packages. It gives the same result as an existing caption checker on a sample file (2 of 8 captions pass, the same six failures).

Checks run locally:

  • npm run skill:validate
  • npm start (adds the README row)
  • npx @microsoft/vally-cli lint skills/caption-qa: 2 of 2 checks passed
  • codespell

I re-read the BBC and DCMP limits on their pages today. The Netflix numbers come from its English (USA) style guide and timing guidelines.

Drafted with AI assistance. Every limit was checked against its source page, and the script was tested on SRT and WebVTT samples.

@markksantos
markksantos requested review from a team as code owners October 25, 2026 17:36
@github-actions github-actions Bot added new-submission PR adds at least one new contribution skills PR touches skills labels Oct 25, 2026
@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 1 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:high — Privileged execution, automation, or review-policy change
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access, including a maintainer with admin or maintain permission.

Why this tier
  • Label needs-review:HIGH flags a high contributor-risk signal

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Skill validation ✅ Passed Passed · logs
Skill lint (vally) ✅ Passed Passed · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s); an approval from a maintainer with admin or maintain permission
  • The core-maintainers pool is not staffed yet; an approver with admin or maintain permission is required instead.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for 8c3d33b · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

🔴 Contributor Reputation Check: HIGH risk

Check Risk
Profile HIGH
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

@github-actions github-actions Bot added needs-review:HIGH Contributor reputation check flagged HIGH risk merge-risk:high and removed merge-risk:medium labels Oct 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Vally Lint Results

✅ All checks passed

Scope Checked
Skills 1
Agents 0
Total 1
Severity Count
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 0

Summary

Level Finding
ℹ️ ✅ caption-qa (2/2 checks passed)
ℹ️ ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
ℹ️ ✓ spec-compliance: All spec checks passed.
ℹ️ ✓ [valid-refs] All file references across 1 skill(s) are valid.
ℹ️ ✓ valid-refs: All file references resolve to existing files within the skill directory.
ℹ️ 1 skill(s) linted, 1 passed
Full linter output
### Linting skills/caption-qa
✅ caption-qa (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.

1 skill(s) linted, 1 passed

@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Oct 25, 2026
@github-actions github-actions Bot added awaiting-automation ready-for-review Submission passed intake validation and is ready for maintainer review and removed ready-for-review Submission passed intake validation and is ready for maintainer review awaiting-automation labels Oct 25, 2026

@aaronpowell aaronpowell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markksantos. This is well sourced, and the per-standard limits table plus the retime-before-reword order are the kind of specifics that help over model defaults.

@aaronpowell
aaronpowell merged commit d106008 into github:main Oct 27, 2026
43 of 46 checks passed
@markksantos

Copy link
Copy Markdown
Contributor Author

@all-contributors add @markksantos for skills

@allcontributors

Copy link
Copy Markdown
Contributor

@markksantos

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@markksantos

Copy link
Copy Markdown
Contributor Author

@all-contributors add @markksantos for content

@allcontributors

Copy link
Copy Markdown
Contributor

@markksantos

I've put up a pull request to add @markksantos! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk:high needs-review:HIGH Contributor reputation check flagged HIGH risk new-submission PR adds at least one new contribution ready-for-review Submission passed intake validation and is ready for maintainer review skills PR touches skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants