Repository navigation
Commit 774ea06
authored
ref(boto3): Rename span origin to
### Description
Rename the boto3 span origin from `auto.http.boto3` to `auto.aws.boto3`,
for every boto3 span including the streamed response body child, and
removes the unused `get_span_origin()` method from `_ServiceExtension`.
### Why
1. `auto.http.boto3` describes the underlying transport/integration
used; boto3 spans are AWS API calls, and (in the future) the ops will be
changed from `http.client` => `rpc`, `db`, `queue.*`, `object.*`, so it
doesn't really fit anymore.
2. JS does the same and uses `auto.aws.aws_sdk`.
### Other option
The other option is to use `auto.rpc.boto3` as the default origin (since
`aws` isn't technically part of the categories, even though JS uses it
https://develop.sentry.dev/sdk/telemetry/traces/trace-origin/) and
override it with the span's op for different services:
- `db` => `auto.db.boto3`
- `queue.*` => `auto.queue.boto3`
- `object.* ` => `auto.object.boto3`
- streamed body child has op `http.client.stream` => `auto.http.boto3`auto.aws.boto3 (#8034)1 parent 6c430fb commit 774ea06
5 files changed
Lines changed: 6 additions & 20 deletions
File tree
- sentry_sdk/integrations/boto3
- _services
- tests/integrations/boto3
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
| 49 | + | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
170 | | - | |
171 | | - | |
| 170 | + | |
| 171 | + | |
172 | 172 | | |
173 | | - | |
174 | 173 | | |
175 | 174 | | |
176 | 175 | | |
177 | 176 | | |
178 | 177 | | |
179 | 178 | | |
180 | 179 | | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | 180 | | |
187 | 181 | | |
188 | 182 | | |
| |||
191 | 185 | | |
192 | 186 | | |
193 | 187 | | |
194 | | - | |
| 188 | + | |
195 | 189 | | |
196 | 190 | | |
197 | 191 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | 24 | | |
29 | 25 | | |
30 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
442 | 442 | | |
443 | 443 | | |
444 | 444 | | |
445 | | - | |
446 | | - | |
447 | | - | |
448 | 445 | | |
449 | 446 | | |
450 | 447 | | |
| |||
476 | 473 | | |
477 | 474 | | |
478 | 475 | | |
479 | | - | |
480 | 476 | | |
481 | 477 | | |
482 | 478 | | |
| |||
486 | 482 | | |
487 | 483 | | |
488 | 484 | | |
489 | | - | |
| 485 | + | |
490 | 486 | | |
491 | 487 | | |
492 | 488 | | |
| |||
0 commit comments