Skip to content

Commit ef34d56

Browse files
msonnbcodex
andcommitted
test(browser): capture exceptions for GraphQL breadcrumb assertions
Co-Authored-By: GPT-6 <codex@openai.com>
1 parent 1c5e872 commit ef34d56

4 files changed

Lines changed: 20 additions & 8 deletions

File tree

  • dev-packages/browser-integration-tests/suites/integrations/graphqlClient

‎dev-packages/browser-integration-tests/suites/integrations/graphqlClient/fetch/test.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,11 @@ sentryTest('should update breadcrumbs for GraphQL fetch requests', async ({ getL
8383
const rootSpanPromise = waitForStreamedSpan(page, span => span.is_segment && getSpanOp(span) === 'pageload');
8484
await page.goto(url);
8585
await rootSpanPromise;
86-
const eventPromise = waitForErrorRequest(page, event => event.message === 'GraphQL request completed');
87-
await page.evaluate(() => (window as any).Sentry.captureMessage('GraphQL request completed'));
86+
const eventPromise = waitForErrorRequest(
87+
page,
88+
event => event.exception?.values?.[0]?.value === 'GraphQL breadcrumb test error',
89+
);
90+
await page.evaluate(() => (window as any).Sentry.captureException(new Error('GraphQL breadcrumb test error')));
8891
const eventData = envelopeRequestParser(await eventPromise);
8992

9093
expect(eventData?.breadcrumbs?.length).toBe(1);

‎dev-packages/browser-integration-tests/suites/integrations/graphqlClient/persistedQuery-fetch/test.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,11 @@ sentryTest(
8585
const rootSpanPromise = waitForStreamedSpan(page, span => span.is_segment && getSpanOp(span) === 'pageload');
8686
await page.goto(url);
8787
await rootSpanPromise;
88-
const eventPromise = waitForErrorRequest(page, event => event.message === 'GraphQL request completed');
89-
await page.evaluate(() => (window as any).Sentry.captureMessage('GraphQL request completed'));
88+
const eventPromise = waitForErrorRequest(
89+
page,
90+
event => event.exception?.values?.[0]?.value === 'GraphQL breadcrumb test error',
91+
);
92+
await page.evaluate(() => (window as any).Sentry.captureException(new Error('GraphQL breadcrumb test error')));
9093
const eventData = envelopeRequestParser(await eventPromise);
9194

9295
expect(eventData?.breadcrumbs?.length).toBe(1);

‎dev-packages/browser-integration-tests/suites/integrations/graphqlClient/persistedQuery-xhr/test.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,11 @@ sentryTest('should update breadcrumbs for GraphQL persisted query XHR requests',
8383
const rootSpanPromise = waitForStreamedSpan(page, span => span.is_segment && getSpanOp(span) === 'pageload');
8484
await page.goto(url);
8585
await rootSpanPromise;
86-
const eventPromise = waitForErrorRequest(page, event => event.message === 'GraphQL request completed');
87-
await page.evaluate(() => (window as any).Sentry.captureMessage('GraphQL request completed'));
86+
const eventPromise = waitForErrorRequest(
87+
page,
88+
event => event.exception?.values?.[0]?.value === 'GraphQL breadcrumb test error',
89+
);
90+
await page.evaluate(() => (window as any).Sentry.captureException(new Error('GraphQL breadcrumb test error')));
8891
const eventData = envelopeRequestParser(await eventPromise);
8992

9093
expect(eventData?.breadcrumbs?.length).toBe(1);

‎dev-packages/browser-integration-tests/suites/integrations/graphqlClient/xhr/test.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,11 @@ sentryTest('should update breadcrumbs for GraphQL XHR requests', async ({ getLoc
8383
const rootSpanPromise = waitForStreamedSpan(page, span => span.is_segment && getSpanOp(span) === 'pageload');
8484
await page.goto(url);
8585
await rootSpanPromise;
86-
const eventPromise = waitForErrorRequest(page, event => event.message === 'GraphQL request completed');
87-
await page.evaluate(() => (window as any).Sentry.captureMessage('GraphQL request completed'));
86+
const eventPromise = waitForErrorRequest(
87+
page,
88+
event => event.exception?.values?.[0]?.value === 'GraphQL breadcrumb test error',
89+
);
90+
await page.evaluate(() => (window as any).Sentry.captureException(new Error('GraphQL breadcrumb test error')));
8891
const eventData = envelopeRequestParser(await eventPromise);
8992

9093
expect(eventData?.breadcrumbs?.length).toBe(1);

0 commit comments

Comments
 (0)