Add convertSpanLinkType helper for OTel span links

Author: andreiborza

packages/deno/src/opentelemetry/tracer.ts

@@ -1,5 +1,5 @@
 import { SENTRY_ORIGIN } from '@sentry/conventions/attributes';
-import type { Context, Span, SpanOptions, Tracer, TracerProvider } from '@opentelemetry/api';
+import type { Context, Link, Span, SpanOptions, Tracer, TracerProvider } from '@opentelemetry/api';
 import { trace } from '@opentelemetry/api';
 import { isObjectLike, startInactiveSpan, startSpanManual } from '@sentry/core';
 import type { SpanLink } from '@sentry/core';
@@ -33,7 +33,7 @@ class SentryDenoTracer implements Tracer {
   public startSpan(name: string, options?: SpanOptions): Span {
     return startInactiveSpan({
       ...options,
-      links: options?.links as SpanLink[] | undefined,
+      links: convertSpanLinkType(options?.links),
       name,
       attributes: {
         ...options?.attributes,
@@ -64,7 +64,7 @@ class SentryDenoTracer implements Tracer {
 
     const spanOpts = {
       ...opts,
-      links: opts.links as SpanLink[] | undefined,
+      links: convertSpanLinkType(opts.links),
       name,
       attributes: {
         ...opts.attributes,
@@ -87,3 +87,14 @@ class SentryDenoTracer implements Tracer {
     return startSpanManual(spanOpts, callback) as ReturnType<F>;
   }
 }
+
+/**
+ * Converts OpenTelemetry span links to Sentry span links.
+ *
+ * Since `@opentelemetry/api` 1.10.0, link attribute values are typed as `unknown`.
+ * Sentry's `SpanLink` only accepts strings, numbers, booleans and arrays of these as attribute values,
+ * so OTel links do not match its type.
+ */
+function convertSpanLinkType(links: Link[] | undefined): SpanLink[] | undefined {
+  return links as SpanLink[] | undefined;
+}

packages/opentelemetry/src/tracer.ts

@@ -17,8 +17,9 @@ import {
   startNewTrace,
   withScope,
 } from '@sentry/core';
-import type { Span, SpanAttributes, SpanLink } from '@sentry/core';
+import type { Span, SpanAttributes } from '@sentry/core';
 import { SENTRY_FORK_SET_ISOLATION_SCOPE_CONTEXT_KEY } from './constants';
+import { convertSpanLinkType } from './utils/convertSpanLinkType';
 import { SENTRY_KIND } from '@sentry/conventions/attributes';
 
 export class SentryTracer implements Tracer {
@@ -134,7 +135,7 @@ export class SentryTracer implements Tracer {
     const sentryOptions = {
       name,
       attributes: (options.attributes as SpanAttributes) || {},
-      links: options.links as SpanLink[] | undefined,
+      links: convertSpanLinkType(options.links),
       startTime: options.startTime,
     };
 

packages/opentelemetry/src/utils/convertSpanLinkType.ts

@@ -0,0 +1,13 @@
+import type { Link } from '@opentelemetry/api';
+import type { SpanLink } from '@sentry/core';
+
+/**
+ * Converts OpenTelemetry span links to Sentry span links.
+ *
+ * Since `@opentelemetry/api` 1.10.0, link attribute values are typed as `unknown`.
+ * Sentry's `SpanLink` only accepts strings, numbers, booleans and arrays of these as attribute values,
+ * so OTel links do not match its type.
+ */
+export function convertSpanLinkType(links: Link[] | undefined): SpanLink[] | undefined {
+  return links as SpanLink[] | undefined;
+}