Skip to content

Commit 65eb3eb

Browse files
mydeaJPeer264
andauthored
Apply batched suggestions from code review
Co-authored-by: Jan Peer Stöcklmair <jan.oster94@gmail.com>
1 parent bf4476e commit 65eb3eb

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

‎packages/node/src/eve.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ interface EveInstrumentationProvider {
3333
* All-in-one Sentry setup for an [eve](https://eve.dev) agent, wired into a single
3434
* `agent/instrumentation/*.ts` provider file.
3535
*
36-
* ```ts
36+
* @example
37+
*
3738
* // agent/instrumentation/sentry.ts
3839
* import * as Sentry from '@sentry/node';
3940
* import { defineInstrumentation } from 'eve/instrumentation';

‎packages/server-utils/src/eve.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export function eveConversationHook(options: EveConversationHookOptions = {}): {
6767
*/
6868
export const eveIntegration = defineIntegration(() => {
6969
return {
70-
name: 'Eve',
70+
name: 'Eve' as const,
7171
setup(client) {
7272
markEveGenAiRecordingDefault(client);
7373
},

‎packages/server-utils/test/integrations/vercel-ai/eve-recording.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ describe('Vercel AI recording under eve', () => {
1717
getMainCarrier().__SENTRY__ = undefined;
1818
});
1919

20-
function setupClient(dataCollection?: { genAI?: { inputs?: boolean } }): void {
20+
function setupClient(dataCollection: { genAI?: { inputs?: boolean } } = {}): void {
2121
const client = new TestClient(
2222
getDefaultTestClientOptions({
2323
dsn: 'https://public@dsn.ingest.sentry.io/1337',
2424
tracesSampleRate: 1,
25-
...(dataCollection ? { dataCollection } : {}),
25+
dataCollection,
2626
}),
2727
);
2828
setCurrentClient(client);

0 commit comments

Comments
 (0)