From 953e4abc1a51abd7f4a946e022b2508e6989955e Mon Sep 17 00:00:00 2001 From: Joshua Li Date: Tue, 25 Aug 2026 18:51:11 -0700 Subject: [PATCH 1/3] chore(gocd): use GitHub App credentials --- gocd/pipelines/relay-experimental.yaml | 3 ++- gocd/templates/libs/utils.libsonnet | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/gocd/pipelines/relay-experimental.yaml b/gocd/pipelines/relay-experimental.yaml index ef5f84eb622..ed1a6f2ae8e 100644 --- a/gocd/pipelines/relay-experimental.yaml +++ b/gocd/pipelines/relay-experimental.yaml @@ -31,7 +31,8 @@ pipelines: checks: environment_variables: # Required for checkruns. - GITHUB_TOKEN: "{{SECRET:[devinfra-github][token]}}" + GITHUB_APP_ID: "{{SECRET:[devinfra-github][app_id]}}" + GITHUB_APP_PRIVATE_KEY: "{{SECRET:[devinfra-github][private_key]}}" timeout: 1800 elastic_profile_id: relay tasks: diff --git a/gocd/templates/libs/utils.libsonnet b/gocd/templates/libs/utils.libsonnet index 888186f576a..48b49437ca9 100644 --- a/gocd/templates/libs/utils.libsonnet +++ b/gocd/templates/libs/utils.libsonnet @@ -18,7 +18,8 @@ local gocdtasks = import 'github.com/getsentry/gocd-jsonnet/libs/gocd-tasks.libs jobs: { checks: { environment_variables: { - GITHUB_TOKEN: '{{SECRET:[devinfra-github][token]}}', + GITHUB_APP_ID: '{{SECRET:[devinfra-github][app_id]}}', + GITHUB_APP_PRIVATE_KEY: '{{SECRET:[devinfra-github][private_key]}}', }, timeout: 1800, elastic_profile_id: 'relay', From d3caa880cdaa343e5c483d4bb40e7f585f28362d Mon Sep 17 00:00:00 2001 From: Joshua Li Date: Thu, 27 Aug 2026 10:38:37 -0700 Subject: [PATCH 2/3] use checkruns2 for GitHub App credentials --- gocd/pipelines/relay-experimental.yaml | 2 +- gocd/templates/bash/github-check-runs.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gocd/pipelines/relay-experimental.yaml b/gocd/pipelines/relay-experimental.yaml index ed1a6f2ae8e..31ea7aed913 100644 --- a/gocd/pipelines/relay-experimental.yaml +++ b/gocd/pipelines/relay-experimental.yaml @@ -37,7 +37,7 @@ pipelines: elastic_profile_id: relay tasks: - script: | - checks-githubactions-checkruns \ + checks-githubactions-checkruns2 \ getsentry/relay \ ${GO_REVISION_RELAY_REPO} \ "Integration Tests" \ diff --git a/gocd/templates/bash/github-check-runs.sh b/gocd/templates/bash/github-check-runs.sh index 732c4edb697..fa92f937a30 100644 --- a/gocd/templates/bash/github-check-runs.sh +++ b/gocd/templates/bash/github-check-runs.sh @@ -1,6 +1,6 @@ #!/bin/bash -checks-githubactions-checkruns \ +checks-githubactions-checkruns2 \ getsentry/relay \ "${GO_REVISION_RELAY_REPO}" \ "Integration Tests" \ From 4b7e8eae55d8fbf5a211ce75855e93d54a5af5a0 Mon Sep 17 00:00:00 2001 From: Joshua Li Date: Thu, 27 Aug 2026 10:40:45 -0700 Subject: [PATCH 3/3] clarify checkruns2 App credential usage --- gocd/pipelines/relay-experimental.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gocd/pipelines/relay-experimental.yaml b/gocd/pipelines/relay-experimental.yaml index 31ea7aed913..b4719c5d1a1 100644 --- a/gocd/pipelines/relay-experimental.yaml +++ b/gocd/pipelines/relay-experimental.yaml @@ -30,7 +30,7 @@ pipelines: jobs: checks: environment_variables: - # Required for checkruns. + # Required for checkruns2. GITHUB_APP_ID: "{{SECRET:[devinfra-github][app_id]}}" GITHUB_APP_PRIVATE_KEY: "{{SECRET:[devinfra-github][private_key]}}" timeout: 1800