Skip to content

Commit d9e226a

Browse files
authored
ci: harden assign-prs and remove mirror-changelog (#86)
1 parent 1167ce3 commit d9e226a

3 files changed

Lines changed: 6 additions & 186 deletions

File tree

‎.github/workflows/assign-prs.yml‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,11 @@
1515
name: PR assignment
1616

1717
on:
18-
pull_request_target:
18+
pull_request_target: # zizmor: ignore[dangerous-triggers] - needs write token on fork PRs; never checks out or runs PR code
1919
types: [opened, edited, reopened]
20+
branches: [main]
21+
22+
permissions: {}
2023

2124
jobs:
2225
auto-assign:
@@ -26,7 +29,7 @@ jobs:
2629
pull-requests: write
2730
steps:
2831
- name: "Auto-assign PR"
29-
uses: pozil/auto-assign-issue@v2
32+
uses: pozil/auto-assign-issue@7bf9d82c77d45976224660b873fc83e60576c5aa # v2
3033
with:
3134
assignees: ajupazhamayil,dolphin1999,rachelhmyang
3235
numOfAssignee: 1

‎.github/workflows/mirror-changelog.yml‎

Lines changed: 0 additions & 151 deletions
This file was deleted.

‎DEVELOPER.md‎

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -96,39 +96,7 @@ The primary maintainers for this repository are defined in the
9696
9797
### Releasing
9898
99-
The release process is automated using `release-please`. It consists of an automated changelog preparation step followed by the manual merging of a Release PR.
100-
101-
#### Automated Changelog Enrichment
102-
103-
Before a Release PR is even created, a special workflow automatically mirrors
104-
relevant changelogs from the core `googleapis/genai-toolbox` dependency. This
105-
ensures that the release notes for this extension accurately reflect important
106-
upstream changes.
107-
108-
The process is handled by the [`mirror-changelog.yml`](.github/workflows/mirror-changelog.yml) workflow:
109-
110-
1. **Trigger:** The workflow runs automatically on pull requests created by
111-
Renovate for `toolbox` version updates.
112-
2. **Parsing:** It reads the detailed release notes that Renovate includes in
113-
the PR body.
114-
3. **Filtering:** These release notes are filtered to include only changes
115-
relevant to this extension. The relevance is determined by a keyword (e.g.,
116-
`mssql`), passed as an environment variable in the workflow file.
117-
4. **Changelog Injection:** The script formats the filtered entries as
118-
conventional commits and injects them into the PR body within a
119-
`BEGIN_COMMIT_OVERRIDE` block.
120-
5. **Release Please:** When the main Release PR is created, `release-please`
121-
reads this override block instead of the standard `chore(deps): ...` commit
122-
message, effectively mirroring the filtered upstream changelog into this
123-
project's release notes.
124-
125-
> **Note for Maintainers:** The filtering script is an automation aid, but it
126-
> may occasionally produce "false positives" (e.g., an internal logging change
127-
> that happens to contain the keyword). Before merging a `toolbox` dependency
128-
> PR, maintainers must **review the generated `BEGIN_COMMIT_OVERRIDE` block**
129-
> and manually delete any lines that are not relevant to the end-users of this
130-
> extension. The curated override block is the final source of truth for the
131-
> release changelog.
99+
The release process is automated using `release-please`. It consists of the manual merging of a Release PR.
132100
133101
#### Release Process
134102

0 commit comments

Comments
 (0)