Repository navigation
MNT build with isolation so setuptools-scm sets the version in docs - #780
Merged
Merged
Conversation
kroq-gar78
changed the title
Building with --no-build-isolation without setuptools-scm installed never generates cortex/_version.py, so cortex.__version__ silently fell back to a hardcoded '1.3.0.dev0'. That is why the published docs show 1.3.0.dev0. --no-build-isolation was added in #385 to work around the numpy 1.20 ABI break. Extensions built against numpy 2 run on numpy 1.x too, so it is no longer needed. Drop it (and the manual build-dependency pre-installs it required) from the CI workflows, README, and install docs, and let pip install build-system.requires from pyproject.toml. Also make the fallback version an obviously-wrong '0+unknown' instead of a real-looking version that goes stale.
The build isolation changes removed the instructions to upgrade setuptools, so now we need to accurately set the minimum.
kroq-gar78
force-pushed
the
yes-build-isolation
branch
from
November 1, 2026 09:08
2c80d09 to
33f0a1a
Compare
kroq-gar78
marked this pull request as ready for review
November 1, 2026 09:43
jwparks
approved these changes
Nov 2, 2026
jwparks
left a comment
jwparks
left a comment
Contributor
There was a problem hiding this comment.
Overall, the change itself looks correct and low-risk to me. Thanks for this maintenance.
Contributor
Author
|
Great, I'm going to merge it now, but let's put off re-publishing the docs until a new release. Right now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published docs for 1.4.0 wrongly show 1.3.0.dev0 in the title.
This is because when building the docs with
--no-build-isolationbut withoutsetuptools-scm,cortex.__version__never gets filled in. It silently falls back to a hardcoded'1.3.0.dev0'.--no-build-isolationwas added in #385 to work around the numpy 1.20 ABI break. Extensions built against numpy 2 run on numpy 1.x too, so it is no longer needed.This PR makes 3 changes:
--no-build-isolationfrom CI and all instructions; pip now automatically installs all packages listed inbuild-system.requiresfrom pyproject.toml.setuptoolsto support Python 3.12+. This is needed because we don't explicitly install or upgrade it anymore.After merging, we should re-publish the docs.