Commit 7e2e90f
committed
fix: use console logger for health check to surface HealthCheckFailed errors
NullLogger.Instance was silently discarding the HealthCheckFailed(uri, exception)
Error-level log that ExecuteAsync emits on connection failures, TLS errors, and
DNS failures. The ILogger parameter was added to 0.0.72.928 specifically to
expose this diagnostic; use a minimal console LoggerFactory so operators can
see why a health check failed.
Prompt: Work on pull request #383 in funfair-tech/BuildBot.1 parent 981276b commit 7e2e90f
1 file changed
Lines changed: 11 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
25 | 28 | | |
26 | | - | |
| 29 | + | |
27 | 30 | | |
28 | | - | |
29 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
30 | 35 | | |
31 | 36 | | |
32 | 37 | | |
| |||
0 commit comments