From c9f5da2960b1891cf8e014b86777f4a4fee283c5 Mon Sep 17 00:00:00 2001 From: MATT ANIS Date: Wed, 1 Jul 2026 00:37:15 +0100 Subject: [PATCH 1/3] removed the chrom installation --- .github/workflows/test-chapter5.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test-chapter5.yml b/.github/workflows/test-chapter5.yml index 44e5bd0..6a6985b 100644 --- a/.github/workflows/test-chapter5.yml +++ b/.github/workflows/test-chapter5.yml @@ -1,8 +1,8 @@ name: E2E tests (library) on: - # push: - # branches: [ main, master ] + push: + branches: [main, master] workflow_dispatch: jobs: @@ -30,10 +30,6 @@ jobs: working-directory: tests-chapter5 run: npm ci - - name: Install Playwright browsers - working-directory: tests-chapter5 - run: npx playwright install chromium --with-deps - - name: Run E2E tests working-directory: tests-chapter5 run: npx playwright test From 6d250761602efbf2be57694c046e65115a860bd1 Mon Sep 17 00:00:00 2001 From: MATT ANIS Date: Wed, 1 Jul 2026 00:38:55 +0100 Subject: [PATCH 2/3] commented back the on push --- .github/workflows/test-chapter5.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-chapter5.yml b/.github/workflows/test-chapter5.yml index 6a6985b..3508e0c 100644 --- a/.github/workflows/test-chapter5.yml +++ b/.github/workflows/test-chapter5.yml @@ -1,9 +1,10 @@ name: E2E tests (library) on: - push: - branches: [main, master] + # push: + # branches: [ main, master ] workflow_dispatch: + jobs: e2e-tests: From 287a69630d48236951c3607209bc16284d29d251 Mon Sep 17 00:00:00 2001 From: MATT ANIS Date: Wed, 1 Jul 2026 00:42:23 +0100 Subject: [PATCH 3/3] added channel chrome --- tests-chapter5/playwright.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests-chapter5/playwright.config.js b/tests-chapter5/playwright.config.js index d4cef8e..5b2ff06 100644 --- a/tests-chapter5/playwright.config.js +++ b/tests-chapter5/playwright.config.js @@ -15,7 +15,7 @@ module.exports = defineConfig({ projects: [ { name: 'chromium', - use: { ...devices['Desktop Chrome'] }, + use: { ...devices['Desktop Chrome'], channel: 'chrome'}, }, ], webServer: [