Fix bug: Grayscale feature does not turn off in allowlisted apps#166
Open
LucaMertens wants to merge 1 commit into
Open
Fix bug: Grayscale feature does not turn off in allowlisted apps#166LucaMertens wants to merge 1 commit into
LucaMertens wants to merge 1 commit into
Conversation
…ady on when starting the service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, first of all: thank you for your work on the app! It's a great idea and I've been using it for a while now.
For the last couple of releases (after upgrading from a previous release), my phone would stay in grayscale mode, even when switching to an allowlisted app. This only happens when the grayscale feature is setup while grayscale is already active.
I believe #143 could also be explained by this.
Steps to reproduce
DISPLAY_DALTONIZER_ENABLED = 1andDISPLAY_DALTONIZER = 0)The fix
Have the app check the current grayscale state at the start of the service and update the internal tracking variable. This prevents saving the grayscale settings as a default.
I tried to keep the change as minimally invasive as possible. I'd be happy to see it merged :)