Fix Windows VIRTUAL_ENV regex and dogfood finecode for docs build

- Give the `for %%i in (...)` and plain `set "VIRTUAL_ENV=..."` forms of
  activate.bat separate capture groups; the shared group previously
  swallowed the `VIRTUAL_ENV=` literal in the plain-set case, so every
  such venv was misdetected as relocated. Add regression tests covering
  both forms on and off relocation.
- Build docs via `finecode run build_docs` in CI instead of invoking
  mkdocs directly, threading FINECODE_LOG_LEVEL through
  setup-dev-workspace.sh and prepare-envs; cache venvs in docs.yml to
  reuse a preceding CI run's install.
- Bump dev workspace Python to 3.14 in ci-cd.yml and docs.yml.
- Drop the unused `dep_graph` optional dependency group from
  pyproject.toml.

Author: Aksem

.github/workflows/ci-cd.yml

@@ -28,7 +28,7 @@ defaults:
 
 env:
   # python version for dev workspace
-  DEV_WORKSPACE_PYTHON_VERSION: '3.13'
+  DEV_WORKSPACE_PYTHON_VERSION: '3.14'
 
 
 jobs:

.github/workflows/docs.yml

@@ -12,26 +12,44 @@ jobs:
 
     steps:
       - uses: actions/checkout@v5
+        with:
+          # setuptools-scm uses tags to get the current version, fetch history and tags
+          # to get correct version
+          fetch-depth: 0
+          fetch-tags: 'true'
+
+      - name: Determine FineCode log level
+        run: |
+          if [ "${RUNNER_DEBUG:-0}" = "1" ]; then
+            echo "FINECODE_LOG_LEVEL=DEBUG" >> "$GITHUB_ENV"
+          else
+            echo "FINECODE_LOG_LEVEL=INFO" >> "$GITHUB_ENV"
+          fi
 
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
-          python-version: '3.13'
+          python-version: '3.14'
 
-      - name: Install docs dependencies
-        run: |
-          python -m pip install --upgrade pip
-          # TODO: prepare_env docs
-          python -m venv .venvs/docs
-          source .venvs/docs/bin/activate
-          python -m pip install --group="docs"
+      # Same cache key pattern as ci-cd.yml so a preceding CI run on the same commit
+      # can seed this cache and skip most of the install work.
+      - name: Cache all venvs
+        uses: actions/cache@v4
+        with:
+          path: |
+            .venvs
+            **/.venvs
+          key: ${{ runner.os }}-venvs-${{ hashFiles('**/pyproject.toml', '**/preset.toml') }}
+
+      - name: Install dependencies
+        run: sh scripts/setup-dev-workspace.sh
 
       - name: Build docs
         env:
           MKDOCS_SITE_URL: https://finecode-dev.github.io
         run: |
-          source .venvs/docs/bin/activate
-          mkdocs build
+          source .venvs/dev_workspace/bin/activate
+          python -m finecode run --log-level="$FINECODE_LOG_LEVEL" build_docs
 
       - name: Deploy to finecode.github.io
         uses: peaceiris/actions-gh-pages@v4

pyproject.toml

@@ -43,7 +43,6 @@ dev_workspace = [
     "opentelemetry-instrumentation==0.62.*"
 ]
 dev = ["psutil==7.2.*", "debugpy==1.8.*"]
-dep_graph = ["fine_dep_graph~=0.1.0a0", "fine_dep_graph_falkordb~=0.1.0a0"]
 
 [build-system]
 requires = ["setuptools>=64", "setuptools-scm>=8"]

scripts/setup-dev-workspace.sh

@@ -46,7 +46,9 @@ recreate_venv() {
     EDITABLE_ARGS=$(python scripts/list_dev_workspace_editables.py)
     uv pip install --python "$VENV_PYTHON" --group dev_workspace $EDITABLE_ARGS -e .
 
-    "$VENV_PYTHON" -m finecode prepare-envs
+    # FINECODE_LOG_LEVEL is set by CI (INFO normally, DEBUG on a debug re-run); it is
+    # unset in the devcontainer, where it falls back to INFO.
+    "$VENV_PYTHON" -m finecode prepare-envs --log-level="${FINECODE_LOG_LEVEL:-INFO}"
 }
 
 if [ -d "$VENV_DIR" ] && is_valid_venv; then

src/finecode/wm_server/runner/finecode_cmd.py

@@ -8,9 +8,14 @@
 
 # activate.bat records the same path, but some generators (e.g. uv) route it through
 # a `for %%i in ("...") do @set "VIRTUAL_ENV=%%~fi"` indirection instead of a plain
-# `set`, so the literal path lives inside the `for ... in (...)` clause.
+# `set "VIRTUAL_ENV=..."`, so the literal path lives inside the `for ... in (...)`
+# clause rather than after `VIRTUAL_ENV=`. The two forms need separate capture groups:
+# a plain `set "VIRTUAL_ENV=<path>"` line quotes the *whole* assignment, not just the
+# path, so a single shared capture group would swallow the `VIRTUAL_ENV=` literal too.
 _VIRTUAL_ENV_WIN_RE = re.compile(
-    r'^\s*(?:@?for\s+%%\w+\s+in\s+\(|@?set\s+)"(?P<path>[^"]+)"', re.MULTILINE | re.IGNORECASE
+    r'^\s*@?for\s+%%\w+\s+in\s+\("(?P<for_path>[^"]+)"\)\s+do\s+@?set\s+"VIRTUAL_ENV=%%~fi"'
+    r'|^\s*@?set\s+"VIRTUAL_ENV=(?P<set_path>[^"]+)"',
+    re.MULTILINE | re.IGNORECASE,
 )
 
 
@@ -54,7 +59,12 @@ def _recorded_venv_path(venv_dir_path: Path) -> Path | None:
     if match is None:
         return None
 
-    return Path(match.group("path"))
+    if sys.platform == "win32":
+        path_str = match.group("for_path") or match.group("set_path")
+    else:
+        path_str = match.group("path")
+
+    return Path(path_str)
 
 
 def get_python_cmd(project_path: Path, env_name: str) -> str:

tests/unit/test_finecode_cmd_windows.py

@@ -0,0 +1,102 @@
+from __future__ import annotations
+
+import pathlib
+
+import pytest
+
+from finecode.wm_server.runner import finecode_cmd
+
+# These tests exercise the win32 branch of `_recorded_venv_path` / `get_python_cmd`
+# regardless of the host OS the suite runs on, by monkeypatching `sys.platform` as
+# seen by `finecode_cmd` and building a Windows-style `Scripts/` venv layout.
+
+
+def _make_windows_venv(
+    venv_dir_path: pathlib.Path, *, activate_bat_content: str
+) -> None:
+    scripts_dir = venv_dir_path / "Scripts"
+    scripts_dir.mkdir(parents=True)
+    (scripts_dir / "python.exe").write_text("")
+    (scripts_dir / "activate.bat").write_text(activate_bat_content)
+
+
+@pytest.fixture(autouse=True)
+def _win32(monkeypatch: pytest.MonkeyPatch) -> None:
+    monkeypatch.setattr(finecode_cmd.sys, "platform", "win32")
+
+
+def test_plain_set_format_is_not_mistaken_for_relocation(
+    tmp_path: pathlib.Path,
+) -> None:
+    """Regression test: a plain `set "VIRTUAL_ENV=<path>"` line quotes the whole
+    assignment, not just the path. The old regex captured everything inside the
+    quotes (including the literal `VIRTUAL_ENV=` prefix), so the recorded path
+    could never equal the real venv path and every such venv looked "relocated"
+    even when it was not.
+    """
+    project_path = tmp_path / "myproject"
+    venv_dir_path = finecode_cmd.get_venv_dir_path(project_path, "dev_workspace")
+    _make_windows_venv(
+        venv_dir_path,
+        activate_bat_content=f'set "VIRTUAL_ENV={venv_dir_path}"\n',
+    )
+
+    result = finecode_cmd.get_python_cmd(project_path, "dev_workspace")
+
+    assert result == (venv_dir_path / "Scripts" / "python.exe").as_posix()
+
+
+def test_plain_set_format_raises_when_path_actually_differs(
+    tmp_path: pathlib.Path,
+) -> None:
+    project_path = tmp_path / "new_location" / "myproject"
+    venv_dir_path = finecode_cmd.get_venv_dir_path(project_path, "dev_workspace")
+    old_venv_dir_path = (
+        tmp_path / "old_location" / "myproject" / ".venvs" / "dev_workspace"
+    )
+    _make_windows_venv(
+        venv_dir_path,
+        activate_bat_content=f'set "VIRTUAL_ENV={old_venv_dir_path}"\n',
+    )
+
+    with pytest.raises(finecode_cmd.VenvRelocatedError):
+        finecode_cmd.get_python_cmd(project_path, "dev_workspace")
+
+
+def test_for_loop_indirection_format_is_not_mistaken_for_relocation(
+    tmp_path: pathlib.Path,
+) -> None:
+    """uv-generated activate.bat files route VIRTUAL_ENV through a
+    `for %%i in ("...") do @set "VIRTUAL_ENV=%%~fi"` indirection instead of a
+    plain `set`."""
+    project_path = tmp_path / "myproject"
+    venv_dir_path = finecode_cmd.get_venv_dir_path(project_path, "dev_workspace")
+    _make_windows_venv(
+        venv_dir_path,
+        activate_bat_content=(
+            f'for %%i in ("{venv_dir_path}") do @set "VIRTUAL_ENV=%%~fi"\n'
+        ),
+    )
+
+    result = finecode_cmd.get_python_cmd(project_path, "dev_workspace")
+
+    assert result == (venv_dir_path / "Scripts" / "python.exe").as_posix()
+
+
+def test_for_loop_indirection_format_raises_when_path_actually_differs(
+    tmp_path: pathlib.Path,
+) -> None:
+    project_path = tmp_path / "new_location" / "myproject"
+    venv_dir_path = finecode_cmd.get_venv_dir_path(project_path, "dev_workspace")
+    old_venv_dir_path = (
+        tmp_path / "old_location" / "myproject" / ".venvs" / "dev_workspace"
+    )
+    _make_windows_venv(
+        venv_dir_path,
+        activate_bat_content=(
+            f'for %%i in ("{old_venv_dir_path}") do @set "VIRTUAL_ENV=%%~fi"\n'
+        ),
+    )
+
+    with pytest.raises(finecode_cmd.VenvRelocatedError):
+        finecode_cmd.get_python_cmd(project_path, "dev_workspace")