-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
[area] fittingUmbrella for fitting related workUmbrella for fitting related work[priority] highShould be prioritized soonShould be prioritized soon[scope] maintenanceCode/tooling cleanup, no feature or bugfix (major.minor.PATCH)Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)
Description
We currently support 3 different minimization engines, all these 3 engines behaves differently when the fit does not converge:
DFO
DFO will throw a FitError with an appropriate error message:

LMFit
LMFit does not throw or warns, but its success flag is properly set to False
Bumps
Bumps does not throw or warns, AND its success flag is wrongly set to True because the fit works and doesn't throw anywhere (it JUST reaches max_iterations).
While not a bug, I also wish to have evaluations as a result in our Result object, so that it can easily be inspected for profiling without having to know its underlying name in our minimizer backends.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
[area] fittingUmbrella for fitting related workUmbrella for fitting related work[priority] highShould be prioritized soonShould be prioritized soon[scope] maintenanceCode/tooling cleanup, no feature or bugfix (major.minor.PATCH)Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)