Fix misplaced form error tooltip#2707
Conversation
richardebeling
requested review from
Kakadus,
hansegucker,
janno42,
niklasmohrin and
richardebeling
| // place tooltip for tomselect based on form-element height | ||
| .tomselected { | ||
| height: 38px; | ||
| } |
There was a problem hiding this comment.
This works for me for now, but I think we're working around a TomSelect bug here: The browser, understandably, renders the information popup relative the the select HTML element that has the required attribute. Tomselect makes this select element 0x0-sized and invisible. They should do something to make the browser tooltip show at the correct position, we shouldn't have to fix this.
It is also broken on their example page: https://tom-select.js.org/examples/validation/
Can we file an issue with them about this, and link it here, to make it clear that this is a workaround for a tomselect bug, not actual styling we want to apply?
(Side note @janno42: What do we think about their bootstrap form error display mechanism for form validation, do we like it? See "Bootstrap" here)
There was a problem hiding this comment.
There was a problem hiding this comment.
Nice. Can we add a short comment in code referencing this issue?
There was a problem hiding this comment.
The bootstrap error display would be even nicer - because it would be consistent with the other fields.
There was a problem hiding this comment.
I have created #2737, so that this can be implemented in future.
3 participants
Closes #2646. Removed height attribute was introduced here.