fix unattended usb tests

Author: Marketen

.github/workflows/debian-iso-e2e.yml

@@ -41,6 +41,9 @@ jobs:
             sudo chmod a+rw /dev/kvm
           fi
 
+      - name: Enable ICMP for QEMU user networking
+        run: sudo sysctl -w net.ipv4.ping_group_range="0 2147483647"
+
       - name: Complete Debian unattended UEFI USB installation
         env:
           E2E_BOOT_MODE: usb

.github/workflows/ubuntu-iso-e2e.yml

@@ -38,6 +38,9 @@ jobs:
             sudo chmod a+rw /dev/kvm
           fi
 
+      - name: Enable ICMP for QEMU user networking
+        run: sudo sysctl -w net.ipv4.ping_group_range="0 2147483647"
+
       - name: Complete Ubuntu unattended UEFI USB installation
         env:
           E2E_BOOT_MODE: usb

scripts/check-disks.sh

@@ -1,6 +1,6 @@
 #!/bin/sh
-#
-# This is run by d-i before the partman step (e.g. d-i partman/early_command)
+# Selects non-USB disks for Debian partitioning before the partman step.
+# It gives GRUB the same targets so the installer USB is never selected.
 
 USBDEV=$(list-devices usb-partition | sed "s/\(.*\)./\1/" | sort -u | head -1 );
 if [ -z "${USBDEV}" ]; then
@@ -12,4 +12,5 @@ for DISK in ${DEVICE}; do
     DISKS="${DISKS} ${DISK}";
 done;
 DISKS=$(echo "${DISKS}" | sed "s/^ //g");
-debconf-set partman-auto/disk "$DISKS"; 
+debconf-set partman-auto/disk "$DISKS";
+debconf-set grub-installer/bootdev "$DISKS";

scripts/dappnode_install.sh

@@ -428,7 +428,16 @@ normalize_ipfs_version_ref() {
         local cid_path="$ref"
         local manifest_url="${IPFS_ENDPOINT%/}${cid_path}/dappnode_package.json"
         local manifest
-        manifest="$(download_stdout "$manifest_url" 2>/dev/null || true)"
+        local attempt
+        for attempt in 1 2 3 4 5; do
+            manifest="$(download_stdout "$manifest_url" 2>/dev/null || true)"
+            if [[ -n "$manifest" ]]; then
+                break
+            fi
+            if [[ "$attempt" -lt 5 ]]; then
+                sleep 2
+            fi
+        done
         if [[ -z "$manifest" ]]; then
             error "Could not fetch IPFS manifest for ${comp} from: $manifest_url"
             error "Provide ${comp}_VERSION as /ipfs/<cid>:<version> (example: /ipfs/Qm...:0.2.11)"