Add sty automation for editor inline comments

[taiya]

e.g.

Preamble

% CR: The following line fails in my standalone LaTex with the error
%     ! Missing \endcsname inserted.
%     I tried fixing it for half an hour but couldn't.
\defeditor{AT}{blue}

Body

\AT{While this is my comment}
\at{This is a sentence edited by me.}

Add this to style file:

% TODO
\newcommand{\defeditorcomment}[2]{%
  \iftoggle{foo}{%
    \expandafter\def\csname#1\endcsname##1{{\color{#2}[#1: ##1]}}%
  }{%
    \expandafter\def\csname#1\endcsname##1{{}}%
  }%
}
\newcommand{\defeditorinline}[2]{%
  \iftoggle{foo}{%
    \expandafter\def\csname#1\endcsname##1{{\color{#2}##1}}%
  }{%
    \expandafter\def\csname#1\endcsname##1{{##1}}%
  }%
}
\newcommand{\defeditor}[2]{%
    \defeditorcomment{#1}{#2}%
    \defeditorinline{\MakeLowercase{#1}}{#2}%
}

[taiya]

These could be disabled by adding a toggle in the sty file:

\newtoggle{foo}
\togglefalse{foo}
\DeclareOption{foo}{\toggletrue{foo}}

[adinriv]

Which editor are you referring to?

What is the main problem?

[taiya]

This is something @cr333 reported ! Missing \endcsname inserted.
I didn't see the error in either vscode or overleaf.
But considering I need to release the template for 3DV, I decided to wait to integrate this feature in the future (to give it more time for testing).

[cr333]

Here are the six full error messages I'm seeing with commit 3a36276 using pdfTeX, Version 3.141592653-2.6-1.40.25 (MiKTeX 23.5) (preloaded format=pdflatex 2023.5.22):

! Missing \endcsname inserted.
<to be read again> 
                   \let 
l.16 \defeditor{AT}{blue}
                         
The control sequence marked <to be read again> should
not appear between \csname and \endcsname.

! LaTeX Error: Missing \begin{document}.

See the LaTeX manual or LaTeX Companion for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.16 \defeditor{AT}{blue}
                         
You're in trouble here.  Try typing  <return>  to proceed.
If that doesn't work, type  X <return>  to quit.

! Extra \endcsname.
<argument> ...sname \MakeLowercase {AT}\endcsname 
                                                  ##1{{##1}}
l.16 \defeditor{AT}{blue}
                         
I'm ignoring this, since I wasn't doing a \csname.

! You can't use `macro parameter character #' in horizontal mode.
<argument> ...ame \MakeLowercase {AT}\endcsname ##
                                                  1{{##1}}
l.16 \defeditor{AT}{blue}
                         
Sorry, but I'm not programmed to handle this case;
I'll just pretend that you didn't ask for it.
If you're in the wrong mode, you might be able to
return to the right one by typing `I}' or `I$' or `I\par'.

! You can't use `macro parameter character #' in horizontal mode.
<argument> ...MakeLowercase {AT}\endcsname ##1{{##
                                                  1}}
l.16 \defeditor{AT}{blue}
                         
Sorry, but I'm not programmed to handle this case;
I'll just pretend that you didn't ask for it.
If you're in the wrong mode, you might be able to
return to the right one by typing `I}' or `I$' or `I\par'.

! Undefined control sequence.
l.55 \at
        {This is a sentence edited by me.}
The control sequence at the end of the top line
of your error message was never \def'ed. If you have
misspelled it (e.g., `\hobx'), type `I' and the correct
spelling (e.g., `I\hbox'). Otherwise just continue,
and I'll forget about whatever was undefined.
)

FYI, preamble.tex line 16 is \defeditor{AT}{blue}

[taiya]

For context, I didn't get any of these errors in Overleaf, nor in vscode+mactex.
So it's a bit harder for me to debug.

[adinriv]

I checked with texlive and texstudio and no errors as well. @cr333 can you provide a MWE? or are you getting this error just with the template?