Skip to content

Commit 4dfa429

Browse files
authored
Merge pull request #1383 from wakqasahmed/fix/issue-1302-nullable-set-identities
fix: allow null in User::setIdentities()
2 parents 15894f2 + 10dc8bc commit 4dfa429

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

‎src/Entities/User.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public function getIdentities(string $type = 'all'): array
126126
return $identities;
127127
}
128128

129-
public function setIdentities(array $identities): void
129+
public function setIdentities(?array $identities): void
130130
{
131131
$this->identities = $identities;
132132
}

‎tests/Unit/UserTest.php‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,17 @@ public function testGetIdentitiesByType(): void
6565
$this->assertEmpty($this->user->getIdentities('foo'));
6666
}
6767

68+
public function testSetIdentitiesNullReloadsIdentities(): void
69+
{
70+
fake(UserIdentityModel::class, ['user_id' => $this->user->id, 'type' => 'password']);
71+
$this->assertCount(1, $this->user->identities);
72+
73+
fake(UserIdentityModel::class, ['user_id' => $this->user->id, 'type' => 'access_token']);
74+
$this->user->identities = null;
75+
76+
$this->assertCount(2, $this->user->getIdentities());
77+
}
78+
6879
public function testModelFindAllWithIdentities(): void
6980
{
7081
fake(UserModel::class);

0 commit comments

Comments
 (0)