Update tests/system/Encryption/Handlers/SodiumHandlerTest.php

gr8man · michalsn · web-flow · commit ac5444dba521 · 2026-06-18T21:40:29.000+02:00
Co-authored-by: Michal Sniatala &lt;michal@sniatala.pl&gt;
diff --git a/tests/system/Encryption/Handlers/SodiumHandlerTest.php b/tests/system/Encryption/Handlers/SodiumHandlerTest.php
@@ -153,13 +153,14 @@ public function testInternalKeyNotModifiedByParams(): void
         $this->assertSame($message, $encrypter->decrypt($encoded, ['key' => $differentKey]));
     }
 
-    public function testBug0IssetThrowsTypeError(): void
+    public function testNullKeyOverrideFallsBackToInstanceKey(): void
     {
-        $this->expectException(EncryptionException::class);
         /** @var SodiumHandler $encrypter */
         $encrypter = $this->encryption->initialize($this->config);
 
-        $encrypter->encrypt('message', ['key' => null]);
+        $ciphertext = $encrypter->encrypt('message', ['key' => null]);
+
+        $this->assertSame('message', $encrypter->decrypt($ciphertext, ['key' => null]));
     }
 
     public function testBug1MemzeroZeroesInternalKey(): void

Original file line number	Diff line number	Diff line change
`@@ -153,13 +153,14 @@ public function testInternalKeyNotModifiedByParams(): void`
`153`	`153`	`$this->assertSame($message, $encrypter->decrypt($encoded, ['key' => $differentKey]));`
`154`	`154`	`}`
`155`	`155`
`156`		`- public function testBug0IssetThrowsTypeError(): void`
	`156`	`+ public function testNullKeyOverrideFallsBackToInstanceKey(): void`
`157`	`157`	`{`
`158`		`- $this->expectException(EncryptionException::class);`
`159`	`158`	`/** @var SodiumHandler $encrypter */`
`160`	`159`	`$encrypter = $this->encryption->initialize($this->config);`
`161`	`160`
`162`		`- $encrypter->encrypt('message', ['key' => null]);`
	`161`	`+ $ciphertext = $encrypter->encrypt('message', ['key' => null]);`
	`162`	`+`
	`163`	`+ $this->assertSame('message', $encrypter->decrypt($ciphertext, ['key' => null]));`
`163`	`164`	`}`
`164`	`165`
`165`	`166`	`public function testBug1MemzeroZeroesInternalKey(): void`