refactor: avoid message-based checks

Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>

Author: memleakd

system/Database/MySQLi/Connection.php

@@ -134,13 +134,7 @@ protected function isCheckConstraintViolation(int|string $code, string $message)
         }
 
         // MariaDB reports CHECK failures as ER_CONSTRAINT_FAILED, while MySQL uses 4025 for other errors.
-        if ($code !== 4025) {
-            return false;
-        }
-
-        $message = strtolower($message);
-
-        return str_contains($message, 'constraint') && str_contains($message, 'failed');
+        return $code === 4025 && str_contains(strtolower($this->getVersion()), 'mariadb');
     }
 
     /**

system/Database/SQLSRV/Connection.php

@@ -117,16 +117,6 @@ protected function isUniqueConstraintViolation(int|string $code, string $message
         return false;
     }
 
-    /**
-     * Checks whether the native database error represents a foreign key constraint violation.
-     */
-    protected function isForeignKeyConstraintViolation(int|string $code, string $message): bool
-    {
-        return $this->getVendorErrorCode($code) === 547
-            && $this->hasSQLState($code, '23000')
-            && str_contains($message, 'FOREIGN KEY constraint');
-    }
-
     /**
      * Checks whether the native database error represents a NOT NULL constraint violation.
      */

tests/system/Database/ConstraintViolationExceptionTest.php

@@ -121,7 +121,7 @@ public static function provideCreatesConstraintViolationExceptions(): iterable
         ];
 
         yield 'MySQLi check MariaDB' => [
-            self::connection(MySQLiConnection::class, 'MySQLi'),
+            self::mysqliConnectionWithVersion('10.11.0-MariaDB'),
             4025,
             'CONSTRAINT `positive_amount` failed.',
             CheckConstraintViolationException::class,
@@ -225,13 +225,6 @@ public static function provideCreatesConstraintViolationExceptions(): iterable
             UniqueConstraintViolationException::class,
         ];
 
-        yield 'SQLSRV foreign key' => [
-            self::connection(SQLSRVConnection::class, 'SQLSRV'),
-            '23000/547',
-            'The INSERT statement conflicted with the FOREIGN KEY constraint.',
-            ForeignKeyConstraintViolationException::class,
-        ];
-
         yield 'SQLSRV generic constraint' => [
             self::connection(SQLSRVConnection::class, 'SQLSRV'),
             '23000/547',
@@ -309,7 +302,7 @@ public function testCreatesBaseDatabaseExceptionForNonConstraintError(): void
 
     public function testCreatesBaseDatabaseExceptionForMySQLiNonConstraint4025(): void
     {
-        $exception = self::connection(MySQLiConnection::class, 'MySQLi')
+        $exception = self::mysqliConnectionWithVersion('8.4.0')
             ->createDatabaseException('InnoDB autoextend size is out of range.', 4025);
 
         $this->assertInstanceOf(DatabaseException::class, $exception);
@@ -348,6 +341,21 @@ private static function connection(string $connectionClass, string $driver): Bas
         return new $connectionClass(self::config($driver));
     }
 
+    private static function mysqliConnectionWithVersion(string $version): BaseConnection
+    {
+        return new class (self::config('MySQLi'), $version) extends MySQLiConnection {
+            public function __construct(array $params, private readonly string $version)
+            {
+                parent::__construct($params);
+            }
+
+            public function getVersion(): string
+            {
+                return $this->version;
+            }
+        };
+    }
+
     /**
      * @return array<string, mixed>
      */

tests/system/Database/Live/ConstraintViolationExceptionTest.php

@@ -13,6 +13,7 @@
 
 namespace CodeIgniter\Database\Live;
 
+use CodeIgniter\Database\Exceptions\ConstraintViolationException;
 use CodeIgniter\Database\Exceptions\ForeignKeyConstraintViolationException;
 use CodeIgniter\Database\Exceptions\NotNullConstraintViolationException;
 use CodeIgniter\Database\Forge;
@@ -70,12 +71,16 @@ public function testThrowsNotNullConstraintViolationExceptionForUpdateWithDebugE
             ->update(['name' => null]);
     }
 
-    public function testThrowsForeignKeyConstraintViolationExceptionWithDebugEnabled(): void
+    public function testThrowsConstraintViolationExceptionForForeignKeyWithDebugEnabled(): void
     {
         $this->enableDBDebug();
         $this->createForeignKeyTables();
 
-        $this->expectException(ForeignKeyConstraintViolationException::class);
+        $expectedException = $this->db->DBDriver === 'SQLSRV'
+            ? ConstraintViolationException::class
+            : ForeignKeyConstraintViolationException::class;
+
+        $this->expectException($expectedException);
 
         $this->db->table('cv_child')->insert([
             'id'        => 1,