test: tighten constraint exception assertions

Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>

Author: memleakd

tests/system/Database/ConstraintViolationExceptionTest.php

@@ -52,9 +52,10 @@ public function testCreatesConstraintViolationExceptions(
         string $message,
         string $expectedException,
     ): void {
-        $exception = $db->createDatabaseException($message, $code);
+        $exception       = $db->createDatabaseException($message, $code);
+        $actualException = $exception::class;
 
-        $this->assertSame($exception::class, $expectedException);
+        $this->assertSame($expectedException, $actualException);
         $this->assertInstanceOf(ConstraintViolationException::class, $exception);
         $this->assertSame($code, $exception->getDatabaseCode());
     }

tests/system/Database/Live/ConstraintViolationExceptionTest.php

@@ -14,6 +14,7 @@
 namespace CodeIgniter\Database\Live;
 
 use CodeIgniter\Database\Exceptions\ConstraintViolationException;
+use CodeIgniter\Database\Exceptions\DatabaseException;
 use CodeIgniter\Database\Exceptions\ForeignKeyConstraintViolationException;
 use CodeIgniter\Database\Exceptions\NotNullConstraintViolationException;
 use CodeIgniter\Database\Forge;
@@ -80,12 +81,18 @@ public function testThrowsConstraintViolationExceptionForForeignKeyWithDebugEnab
             ? ConstraintViolationException::class
             : ForeignKeyConstraintViolationException::class;
 
-        $this->expectException($expectedException);
+        try {
+            $this->db->table('cv_child')->insert([
+                'id'        => 1,
+                'parent_id' => 999,
+            ]);
 
-        $this->db->table('cv_child')->insert([
-            'id'        => 1,
-            'parent_id' => 999,
-        ]);
+            $this->fail('Expected database exception was not thrown.');
+        } catch (DatabaseException $e) {
+            $actualException = $e::class;
+
+            $this->assertSame($expectedException, $actualException);
+        }
     }
 
     public function testStoresNotNullConstraintViolationExceptionWithDebugDisabled(): void