From 4ef8b832a14662dade3bc42c30be7c74ed66e438 Mon Sep 17 00:00:00 2001 From: Ned Petrov Date: Thu, 2 Jul 2026 15:46:32 +0300 Subject: [PATCH 1/5] Fix missing cloud config update in new network tests The refactor in PR #54 replaced @requirements.requirement(@deployment, @spec) with direct with_deployment + bosh deploy calls, silently dropping the update_cloud_config step. When these tests run in isolation (e.g. with tag filtering), the director has no cloud config and all deployments fail with "Required property 'networks' was not specified". --- spec/system/ipv6_network_configuration_spec.rb | 2 ++ spec/system/network_configuration_spec.rb | 1 + 2 files changed, 3 insertions(+) diff --git a/spec/system/ipv6_network_configuration_spec.rb b/spec/system/ipv6_network_configuration_spec.rb index d91b8d5..5bcd951 100644 --- a/spec/system/ipv6_network_configuration_spec.rb +++ b/spec/system/ipv6_network_configuration_spec.rb @@ -16,6 +16,7 @@ use_static_ip use_multiple_manual_networks @deployment = with_deployment + @requirements.update_cloud_config(@spec) expect(bosh("-d #{@deployment.name} deploy #{@deployment.to_path}")).to succeed end @@ -47,6 +48,7 @@ use_instance_count(2) @deployment = with_deployment + @requirements.update_cloud_config(@spec) expect(bosh("-d #{@deployment.name} deploy #{@deployment.to_path}")).to succeed end diff --git a/spec/system/network_configuration_spec.rb b/spec/system/network_configuration_spec.rb index 07ce372..7bf480d 100644 --- a/spec/system/network_configuration_spec.rb +++ b/spec/system/network_configuration_spec.rb @@ -51,6 +51,7 @@ use_multiple_manual_networks @deployment = with_deployment + @requirements.update_cloud_config(@spec) expect(bosh("-d #{@deployment.name} deploy #{@deployment.to_path}")).to succeed end From c856d50807af8e6ddc2867327dcb72f41bd9d21e Mon Sep 17 00:00:00 2001 From: Ned Petrov Date: Thu, 2 Jul 2026 17:01:20 +0300 Subject: [PATCH 2/5] Add base64 to Gemfile (removed from Ruby 3.4 default gems) --- Gemfile | 1 + 1 file changed, 1 insertion(+) diff --git a/Gemfile b/Gemfile index 997a73b..82f3e43 100644 --- a/Gemfile +++ b/Gemfile @@ -10,3 +10,4 @@ gem 'minitar' gem 'rspec' gem 'ed25519' gem 'bcrypt_pbkdf' +gem 'base64' From 4e5b05caa8f806eab624539828bad3aa1a9abd1d Mon Sep 17 00:00:00 2001 From: Ned Petrov Date: Thu, 2 Jul 2026 21:59:45 +0300 Subject: [PATCH 3/5] Add sudo to the ping6 command --- spec/system/ipv6_network_configuration_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/system/ipv6_network_configuration_spec.rb b/spec/system/ipv6_network_configuration_spec.rb index 5bcd951..1c465f7 100644 --- a/spec/system/ipv6_network_configuration_spec.rb +++ b/spec/system/ipv6_network_configuration_spec.rb @@ -127,7 +127,7 @@ instances_usable_ips.each do |target_instance, data| next if source_instance == target_instance # Skip pinging self - ping_result = bosh_ssh(source_name, source_id, "ping6 -c 5 #{data[:usable_ip]}", + ping_result = bosh_ssh(source_name, source_id, "sudo ping6 -c 5 #{data[:usable_ip]}", deployment: @deployment.name, result: true, column: 'stdout').output success = ping_result.match(/0% packet loss/) || ping_result.match(/\d+ packets transmitted, \d+ received/) expect(success).to be_truthy, From 2ceff35832f20c65265e1276bf9dd4a2b0dc5636 Mon Sep 17 00:00:00 2001 From: Ned Petrov <71276794+neddp@users.noreply.github.com> Date: Thu, 2 Jul 2026 22:00:50 +0300 Subject: [PATCH 4/5] Update Gemfile --- Gemfile | 2 -- 1 file changed, 2 deletions(-) diff --git a/Gemfile b/Gemfile index da8f222..1d73877 100644 --- a/Gemfile +++ b/Gemfile @@ -12,8 +12,6 @@ gem 'net-ssh' gem 'net-ssh-gateway' gem 'rspec' -gem 'ed25519' -gem 'bcrypt_pbkdf' gem 'base64' gem 'logger' # Ruby 4.x gem 'ostruct' # Ruby 4.x - used by `bosh-template` From 8fd67097da0b264acf16c86e87b54c64a6fa669b Mon Sep 17 00:00:00 2001 From: Ned Petrov <71276794+neddp@users.noreply.github.com> Date: Fri, 3 Jul 2026 14:19:21 +0300 Subject: [PATCH 5/5] Update Gemfile --- Gemfile | 1 - 1 file changed, 1 deletion(-) diff --git a/Gemfile b/Gemfile index 1d73877..87ca1f5 100644 --- a/Gemfile +++ b/Gemfile @@ -12,6 +12,5 @@ gem 'net-ssh' gem 'net-ssh-gateway' gem 'rspec' -gem 'base64' gem 'logger' # Ruby 4.x gem 'ostruct' # Ruby 4.x - used by `bosh-template`