Classic Era spits errors

[k9dog-gmail]

Classic Era is 1.14.3. This addon claims to be Classic Era compatible. The errors seem to indicate otherwise. I know some errors might be expected due to people requesting Wrath, but would be nice to know status. I'll try downloading Wrath version and see if file lave just is wrongly indicating.

[Dragotex]

same problem for me - can you please fix it - this addon is so great and works so perfect with adi bags!!!!

[GovtGeek]

I don't currently have a classic era character, but I'll see what I can do. If nothing else, you should be able to use a previous version.

[DeTosc]

AFAIK, Blizzard changed the Lua API in 1.14.x (Era) to ... Shadowlands(?), introducing the infamous "Backdrop" errors to Era:

27x ...tter\Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:165: attempt to call method 'SetBackdrop' (a nil value)

The good news is: The BCC version Outfitter-2.0.64.TBC seems to work fine for me.

[GovtGeek]

I created a new character to test in Classic. There were issues with the some namespace changes (C_Container being a major one). I have a fix I'm testing and hopefully should be available soon.

[GovtGeek]

Can you test out my draft release from my fork?
https://github.com/GovtGeek/Outfitter/releases/tag/3.0.4.6

[DeTosc]

I'am afraid that something went wrong and you rereleased the assets of the (not working) version 3.0.4 from 25 january 2023.
Look:
5x Interface\AddOns\Outfitter\OutfitterInventory.lua:845: attempt to index global 'C_Container' (a nil value)
[string "@interface\AddOns\Outfitter\OutfitterInventory.lua"]:845: in function Synchronize' [string "@Interface\AddOns\Outfitter\OutfitterInventory.lua"]:760: in function GetInventoryCache'
[string "@interface\AddOns\Outfitter\Outfitter-3.0.4.lua"]:4018: in function GetNewItemsOutfit' [string "@Interface\AddOns\Outfitter\OutfitterEquipment.lua"]:991: in function RestoreSavedStack'
[string "@interface\AddOns\Outfitter\OutfitterEquipment.lua"]:969: in function Initialize' [string "@Interface\AddOns\Outfitter\Outfitter-3.0.4.lua"]:4778: in function Function'
[string "@interface\AddOns\Outfitter\Libraries/MC2SchedulerLib/MC2SchedulerLib.lua"]:242: in function OnUpdate2' [string "@Interface\AddOns\Outfitter\Libraries/MC2SchedulerLib/MC2SchedulerLib.lua"]:178: in function OnUpdate'
[string "@interface\AddOns\Outfitter\Libraries/MC2SchedulerLib/MC2SchedulerLib.lua"]:20: in function <...fitter\Libraries/MC2SchedulerLib/MC2SchedulerLib.lua:20>

[GovtGeek]

Was that on login or did you do something specific?

[DeTosc]

I am using the BugGrabber/Bugsack Addons, which intercept&show all the Lua errors. And this shows up right after login.
Please check the assets attached to your release, these dates seems wrong to me:

[GovtGeek]

I have a new release package up. Looks like I didn't package up the branch like I thought.

[DeTosc]

I confirm: No Lua errors on login and switching gear while riding works fine. It seems that we have a winner :)

[Dragotex]

Now i get errors with ADI bags when i activate the latest Outfitter, now lua error with deactivated outfitter:

Message: Interface\AddOns\AdiBags\core\Utility.lua:465: attempt to call field 'GetContainerItemQuestInfo' (a nil value)
Time: Wed Apr 19 03:33:38 2023
Count: 74
Stack: Interface\AddOns\AdiBags\core\Utility.lua:465: attempt to call field 'GetContainerItemQuestInfo' (a nil value)
[string "=[C]"]: in function GetContainerItemQuestInfo' [string "@Interface\AddOns\AdiBags\core\Utility.lua"]:465: in function GetContainerItemQuestInfo'
[string "@interface\AddOns\AdiBags\widgets\ItemButton.lua"]:333: in function UpdateIcon' [string "@Interface\AddOns\AdiBags\widgets\ItemButton.lua"]:344: in function Update'
[string "@interface\AddOns\AdiBags\widgets\ItemButton.lua"]:319: in function FullUpdate' [string "@Interface\AddOns\AdiBags\widgets\ItemButton.lua"]:276: in function <Interface\AddOns\AdiBags\widgets\ItemButton.lua:264> [string "=[C]"]: in function Show'
[string "@interface\AddOns\AdiBags\widgets\ContainerFrame.lua"]:1093: in function PrepareSections' [string "@Interface\AddOns\AdiBags\widgets\ContainerFrame.lua"]:1215: in function FullUpdate'
[string "@interface\AddOns\AdiBags\widgets\ContainerFrame.lua"]:643: in function <Interface\AddOns\AdiBags\widgets\ContainerFrame.lua:629>
[string "=[C]"]: ?
[string "@interface\AddOns\AdiBags\core\Utility.lua"]:106: in function <Interface\AddOns\AdiBags\core\Utility.lua:98>
[string "@interface\AddOns\AdiBags\widgets\LayeredRegion.lua"]:119: in function <Interface\AddOns\AdiBags\widgets\LayeredRegion.lua:108>

[GovtGeek]

That looks to be an issue with AdiBags not fixing the GetContainerItemQuestInfo call to a C_Container.GetContainerItemQuestInfo call. The change I made took out a bunch of C_Container fixes for things Outfitter didn't use.

[GovtGeek]

I took another look at the code. The current iteration of my fix ends up being global and affects other addons, instead of local to Outfitter as intended.

I'll work on trying to get it localized so it won't affect other addons.