Initialize WIN32_FIND_DATA fields before calling GetPath

Vadim Belov · Vadim Belov · commit 071feb43c5de · 2025-12-09T10:01:01.000-08:00
Fully initialize all fields of WIN32_FIND_DATAW.Data and set dwFileAttributes of WIN32_FIND_DATAA.Data to 0 before passing them to the respective GetPath methods. This prevents potential issues from uninitialized structure data.
diff --git a/Sources/EasyExtensions.Windows/ShellLink.cs b/Sources/EasyExtensions.Windows/ShellLink.cs
@@ -730,11 +730,22 @@ public string Target
                 if (linkA == null && linkW != null)
                 {
                     WIN32_FIND_DATAW fd = new WIN32_FIND_DATAW();
+                    fd.Data.ftCreationTime = new FILETIME();
+                    fd.Data.ftLastAccessTime = new FILETIME();
+                    fd.Data.ftLastWriteTime = new FILETIME();
+                    fd.Data.dwFileAttributes = 0;
+                    fd.Data.nFileSizeLow = 0;
+                    fd.Data.nFileSizeHigh = 0;
+                    fd.Data.dwReserved0 = 0;
+                    fd.Data.dwReserved1 = 0;
+                    fd.Data.cFileName = string.Empty;
+                    fd.Data.cAlternateFileName = string.Empty;
                     linkW.GetPath(target, target.Capacity, ref fd, (uint)EShellLinkGP.SLGP_UNCPRIORITY);
                 }
                 else if (linkA != null && linkW == null)
                 {
                     WIN32_FIND_DATAA fd = new WIN32_FIND_DATAA();
+                    fd.Data.dwFileAttributes = 0;
                     linkA.GetPath(target, target.Capacity, ref fd, (uint)EShellLinkGP.SLGP_UNCPRIORITY);
                 }
                 else

Original file line number	Diff line number	Diff line change
`@@ -730,11 +730,22 @@ public string Target`
`730`	`730`	`if (linkA == null && linkW != null)`
`731`	`731`	`{`
`732`	`732`	`WIN32_FIND_DATAW fd = new WIN32_FIND_DATAW();`
	`733`	`+ fd.Data.ftCreationTime = new FILETIME();`
	`734`	`+ fd.Data.ftLastAccessTime = new FILETIME();`
	`735`	`+ fd.Data.ftLastWriteTime = new FILETIME();`
	`736`	`+ fd.Data.dwFileAttributes = 0;`
	`737`	`+ fd.Data.nFileSizeLow = 0;`
	`738`	`+ fd.Data.nFileSizeHigh = 0;`
	`739`	`+ fd.Data.dwReserved0 = 0;`
	`740`	`+ fd.Data.dwReserved1 = 0;`
	`741`	`+ fd.Data.cFileName = string.Empty;`
	`742`	`+ fd.Data.cAlternateFileName = string.Empty;`
`733`	`743`	`linkW.GetPath(target, target.Capacity, ref fd, (uint)EShellLinkGP.SLGP_UNCPRIORITY);`
`734`	`744`	`}`
`735`	`745`	`else if (linkA != null && linkW == null)`
`736`	`746`	`{`
`737`	`747`	`WIN32_FIND_DATAA fd = new WIN32_FIND_DATAA();`
	`748`	`+ fd.Data.dwFileAttributes = 0;`
`738`	`749`	`linkA.GetPath(target, target.Capacity, ref fd, (uint)EShellLinkGP.SLGP_UNCPRIORITY);`
`739`	`750`	`}`
`740`	`751`	`else`