Skip to content

Conversation

@davedwwang
Copy link
Contributor

Why are the changes needed?

To improve the robustness of the CI/CD pipeline.

Close #4030.

Brief change log

  1. Introduce maven-enforcer-plugin: Add the plugin to the amoro-ams (or root) pom.xml.\
  2. Add JUnit 5 Engine Check: Ensure that if the project has dependencies, it must contain junit-jupiter-engine to prevent silent ignoring of JUnit 5 tests.
  3. Add JUnit 4 Engine Check: Ensure that junit-vintage-engine is present to support the execution of legacy JUnit 4 tests.
  4. Align with Apache Paimon Security Standards: Referenced the security practices of Apache Paimon to introduce stricter dependency validation.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • [ x] Run test locally before making a pull request

@github-actions github-actions bot added module:mixed-flink Flink moduel for Mixed Format module:ams-server Ams server module type:build module:common labels Jan 3, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.85%. Comparing base (cbdc517) to head (48db502).
⚠️ Report is 25 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4031      +/-   ##
============================================
+ Coverage     22.12%   22.85%   +0.72%     
- Complexity     2461     2531      +70     
============================================
  Files           445      449       +4     
  Lines         40897    41048     +151     
  Branches       5767     5784      +17     
============================================
+ Hits           9050     9380     +330     
+ Misses        31089    30859     -230     
- Partials        758      809      +51     
Flag Coverage Δ
trino 22.85% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module module:common module:mixed-flink Flink moduel for Mixed Format type:build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Enforce build constraints using maven-enforcer-plugin

2 participants