From 71999f1e400b0984c97801c880325f09e4040243 Mon Sep 17 00:00:00 2001 From: craigsturgess Date: Thu, 15 Jan 2026 09:30:39 +0000 Subject: [PATCH] Simplify GetPixels by removing redundant checks Removed redundant null checks for pValueBuffer and m_PixelData, these checks stops the two-call pattern of the GetPixels(). --- Implementation/LibMCEnv/libmcenv_imagedata.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Implementation/LibMCEnv/libmcenv_imagedata.cpp b/Implementation/LibMCEnv/libmcenv_imagedata.cpp index aff0afa2..fb9c843b 100644 --- a/Implementation/LibMCEnv/libmcenv_imagedata.cpp +++ b/Implementation/LibMCEnv/libmcenv_imagedata.cpp @@ -888,18 +888,10 @@ void CImageData::GetPixels(const LibMCEnv_uint32 nStartX, const LibMCEnv_uint32 { if (m_PixelData.get() == nullptr) throw ELibMCEnvInterfaceException(LIBMCENV_ERROR_INVALIDIMAGEBUFFER); - - if (pValueBuffer == nullptr) - throw ELibMCEnvInterfaceException(LIBMCENV_ERROR_INVALIDPARAM); - - if (m_PixelData.get() == nullptr) - throw ELibMCEnvInterfaceException(LIBMCENV_ERROR_INVALIDIMAGEBUFFER); - if (nCountX <= 0) throw ELibMCEnvInterfaceException(LIBMCENV_ERROR_INVALIDPIXELCOUNT); if (nCountY <= 0) throw ELibMCEnvInterfaceException(LIBMCENV_ERROR_INVALIDPIXELCOUNT); - if (nStartX >= m_nPixelCountX) throw ELibMCEnvInterfaceException(LIBMCENV_ERROR_INVALIDXCOORDINATE); if (nStartY >= m_nPixelCountY)