Skip to content

Insecure git clone in import-gnulib.sh #1

@kpcyrd

Description

@kpcyrd

Hello!

Just letting you know, the following lines:

git_repo="git://git.savannah.gnu.org/gnulib.git"

# ...

	if test -d gnulib/.git ; then
	  echo "Git repository was already initialised."
	else
	  echo "Cloning the git repository..."
	  # In the future we may use a shallow clone to 
	  # save bandwidth.
	  git clone "$git_repo"
	fi
	cd gnulib
	set -x
	git fetch origin
	git checkout "$gnulib_version"
	set +x

Are not secure to run, it's pulling executable code over an unauthenticated network connection, similar to how curl http://... | sh isn't secure.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions