Follow-up to #467 review feedback (pr-workflow.yaml thread).
#467 added a one-off CI step that re-runs ./internal/imagecache/ under sudo so its root-gated tests (overlay mounts, whiteout mknod, trusted.* xattrs) execute instead of skipping. As more packages grow privileged tests, this shouldn't be a hardcoded package list.
Proposal: a repo-wide convention that a single CI step can discover — e.g. tests self-gate with t.Skip when unprivileged (as imagecache already does) and CI runs sudo -E go test for a designated set discovered via a build tag (//go:build roottest), a naming convention, or a small manifest. Should also document how to run them locally (sudo go test ./internal/imagecache/) in the contributor docs.
Follow-up to #467 review feedback (pr-workflow.yaml thread).
#467 added a one-off CI step that re-runs
./internal/imagecache/undersudoso its root-gated tests (overlay mounts, whiteout mknod, trusted.* xattrs) execute instead of skipping. As more packages grow privileged tests, this shouldn't be a hardcoded package list.Proposal: a repo-wide convention that a single CI step can discover — e.g. tests self-gate with
t.Skipwhen unprivileged (as imagecache already does) and CI runssudo -E go testfor a designated set discovered via a build tag (//go:build roottest), a naming convention, or a small manifest. Should also document how to run them locally (sudo go test ./internal/imagecache/) in the contributor docs.