From 54d78ca448420203d5ae68dbec5172c7f8aa69b5 Mon Sep 17 00:00:00 2001 From: Gernot Maier Date: Mon, 15 Jun 2026 20:45:27 +0200 Subject: [PATCH 1/2] v492-rc5 --- CHANGELOG.md | 24 ++++++++++++++++++++++++ docs/changes/351.bugfix.md | 2 -- docs/changes/352.bugfix.md | 5 ----- docs/changes/353.bugfix.md | 7 ------- docs/changes/358.maintenance.md | 1 - 5 files changed, 24 insertions(+), 15 deletions(-) delete mode 100644 docs/changes/351.bugfix.md delete mode 100644 docs/changes/352.bugfix.md delete mode 100644 docs/changes/353.bugfix.md delete mode 100644 docs/changes/358.maintenance.md diff --git a/CHANGELOG.md b/CHANGELOG.md index 0430192e..8b6dd945 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,30 @@ This changelog is generated using [Towncrier](https://towncrier.readthedocs.io/) +## [v492.0-rc5](https://github.com/VERITAS-Observatory/EventDisplay_v4/releases/tag/v492.0-rc5) - 2026-06-15 + +### Bugfixes + +- Fixes long list of bugs listed in [Issue #352](https://github.com/VERITAS-Observatory/EventDisplay_v4/issues/352). + Fix A2: `VTraceHandler::calculateTraceSum_slidingWindow()` fRaw branch returned `FADC[1]` (second FADC sample, ped-subtracted) instead of the accumulated raw charge sum. Affected pedestal calculation path. ([#351](https://github.com/VERITAS-Observatory/EventDisplay_v4/issues/351)) +- # Bug fix: non-XGB jobs no longer probe XGB sidecar files (E4) + + XGB sidecar files (stereo and gamma-hadron) are now opened only when the active + reconstruction method and gamma-hadron cut type actually require them, eliminating + spurious ROOT file-open errors in non-XGB jobs. ([#352](https://github.com/VERITAS-Observatory/EventDisplay_v4/issues/352)) +- # Bug fix: explicit NegWeightTreatment for TMVA Gradient BDT angular reconstruction + + Added `NegWeightTreatment=Pray` to the default TMVA options in + `trainTMVAforAngularReconstruction` to match actual TMVA behaviour: + `BoostType=Grad` does not support `InverseBoostNegWeights` (TMVA's global + default) and silently replaces it with `Pray`; the options string now + declares this explicitly so the training configuration matches what is used. ([#353](https://github.com/VERITAS-Observatory/EventDisplay_v4/issues/353)) + +### Maintenance + +- Updates to allow for compilation with ROOT >=v6.38. Adjustment of CI. ([#358](https://github.com/VERITAS-Observatory/EventDisplay_v4/issues/358)) + + ## [v492.0-rc4](https://github.com/VERITAS-Observatory/EventDisplay_v4/releases/tag/v492.0-rc4) - 2026-05-17 ### New Feature diff --git a/docs/changes/351.bugfix.md b/docs/changes/351.bugfix.md deleted file mode 100644 index 66290ef3..00000000 --- a/docs/changes/351.bugfix.md +++ /dev/null @@ -1,2 +0,0 @@ -Fixes long list of bugs listed in [Issue #352](https://github.com/VERITAS-Observatory/EventDisplay_v4/issues/352). -Fix A2: `VTraceHandler::calculateTraceSum_slidingWindow()` fRaw branch returned `FADC[1]` (second FADC sample, ped-subtracted) instead of the accumulated raw charge sum. Affected pedestal calculation path. diff --git a/docs/changes/352.bugfix.md b/docs/changes/352.bugfix.md deleted file mode 100644 index 7b828512..00000000 --- a/docs/changes/352.bugfix.md +++ /dev/null @@ -1,5 +0,0 @@ -# Bug fix: non-XGB jobs no longer probe XGB sidecar files (E4) - -XGB sidecar files (stereo and gamma-hadron) are now opened only when the active -reconstruction method and gamma-hadron cut type actually require them, eliminating -spurious ROOT file-open errors in non-XGB jobs. diff --git a/docs/changes/353.bugfix.md b/docs/changes/353.bugfix.md deleted file mode 100644 index 14b2bfb5..00000000 --- a/docs/changes/353.bugfix.md +++ /dev/null @@ -1,7 +0,0 @@ -# Bug fix: explicit NegWeightTreatment for TMVA Gradient BDT angular reconstruction - -Added `NegWeightTreatment=Pray` to the default TMVA options in -`trainTMVAforAngularReconstruction` to match actual TMVA behaviour: -`BoostType=Grad` does not support `InverseBoostNegWeights` (TMVA's global -default) and silently replaces it with `Pray`; the options string now -declares this explicitly so the training configuration matches what is used. diff --git a/docs/changes/358.maintenance.md b/docs/changes/358.maintenance.md deleted file mode 100644 index bbde6d5a..00000000 --- a/docs/changes/358.maintenance.md +++ /dev/null @@ -1 +0,0 @@ -Updates to allow for compilation with ROOT >=v6.38. Adjustment of CI. From 0fd23d822b6d0b89b7093f43e15dc9444de06304 Mon Sep 17 00:00:00 2001 From: Gernot Maier Date: Mon, 15 Jun 2026 20:47:16 +0200 Subject: [PATCH 2/2] format --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8b6dd945..52da8063 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,12 +15,12 @@ This changelog is generated using [Towncrier](https://towncrier.readthedocs.io/) - Fixes long list of bugs listed in [Issue #352](https://github.com/VERITAS-Observatory/EventDisplay_v4/issues/352). Fix A2: `VTraceHandler::calculateTraceSum_slidingWindow()` fRaw branch returned `FADC[1]` (second FADC sample, ped-subtracted) instead of the accumulated raw charge sum. Affected pedestal calculation path. ([#351](https://github.com/VERITAS-Observatory/EventDisplay_v4/issues/351)) -- # Bug fix: non-XGB jobs no longer probe XGB sidecar files (E4) +- Bug fix: non-XGB jobs no longer probe XGB sidecar files (E4) XGB sidecar files (stereo and gamma-hadron) are now opened only when the active reconstruction method and gamma-hadron cut type actually require them, eliminating spurious ROOT file-open errors in non-XGB jobs. ([#352](https://github.com/VERITAS-Observatory/EventDisplay_v4/issues/352)) -- # Bug fix: explicit NegWeightTreatment for TMVA Gradient BDT angular reconstruction +- Bug fix: explicit NegWeightTreatment for TMVA Gradient BDT angular reconstruction Added `NegWeightTreatment=Pray` to the default TMVA options in `trainTMVAforAngularReconstruction` to match actual TMVA behaviour: