fix: Missing Delete key handlers by matthewlipski · Pull Request #2126 · TypeCellOS/BlockNote

matthewlipski · 2025-10-23T14:45:13Z

Summary

This PR adds full Delete key handling, building on the existing logic. The additional cases are mainly for nested blocks and multi-column blocks.

R.e. multi-column, Backspace key handling has also been slightly changed to be more consistent. Specifically, whenever a block moves into a column after pressing Backspace or Delete, it now always gets added as a new block. Previously, it would sometimes be merged with the current block.

Rationale

While Delete isn't used as much as Backspace, proper handling for it is still needed.

Changes

Added cases for Delete key handling.
Added a case for Backspace key handling when right after columnList.
Added getNextBlockInfo helper.
Updated getParentBlockInfo helper.

Impact

N/A

Testing

Added e2e tests for Delete key handling:

Basic functionality (merging adjacent blocks, deleting selection, etc.)
Nested blocks (merging child with parent, merging next block with child, etc.)
Multi-column (moving the first block from the next column into the current one, moving the first block in a column list out of it, etc.)

Screenshots/Video

N/A

Checklist

Code follows the project's coding standards.
Unit tests covering the new feature have been added.
All existing tests pass.
The documentation has been updated to reflect the new feature

Additional Notes

vercel · 2025-10-23T14:45:18Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
blocknote	Ready	Preview	Feb 24, 2026 11:43am
blocknote-website	Ready	Preview	Feb 24, 2026 11:43am

pkg-pr-new · 2025-10-23T14:53:48Z

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/ariakit@2126

@blocknote/code-block

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/code-block@2126

@blocknote/core

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/core@2126

@blocknote/mantine

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/mantine@2126

@blocknote/react

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/react@2126

@blocknote/server-util

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/server-util@2126

@blocknote/shadcn

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/shadcn@2126

@blocknote/xl-ai

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-ai@2126

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-docx-exporter@2126

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-email-exporter@2126

@blocknote/xl-multi-column

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-multi-column@2126

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-odt-exporter@2126

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-pdf-exporter@2126

commit: 9448f41

packages/core/src/extensions/tiptap-extensions/KeyboardShortcuts/KeyboardShortcutsExtension.ts

nperez0111

Will hold on this until we get that PR through

packages/core/src/api/blockManipulation/commands/mergeBlocks/mergeBlocks.ts

nperez0111 · 2026-02-24T10:02:48Z

packages/core/src/extensions/tiptap-extensions/KeyboardShortcuts/KeyboardShortcutsExtension.ts

+            if (
+              !prevBlockInfo ||
+              !prevBlockInfo.isBlockContainer ||
+              prevBlockInfo.blockContent.node.type.spec.content !== "inline*"
+            ) {
+              return false;
+            }


can we add a todo on why we early return here

Not really a TODO, we return early intentionally as we can't merge blocks unless they both have inline content. Otherwise, we delete the previous block, which is handled in a different command.

Also if the previous block is a column list, that also gets handled separately

Sorry not a todo, a comment

nperez0111 · 2026-02-24T10:04:45Z

packages/core/src/extensions/tiptap-extensions/KeyboardShortcuts/KeyboardShortcutsExtension.ts

                tr.setSelection(
-                  TextSelection.near(tr.doc.resolve($columnPos.pos - 1)),
+                  TextSelection.near(tr.doc.resolve($columnPos.pos)),


text selection is after now? Intentional?

Wdym? Like it's after fixColumnList or the selection itself is different?

This changes the position of where the selection is restored to (at least from the previous behavior) is it intentional?

nperez0111

How do you test the delete key on macOS? I'm unsure how to do it

packages/core/src/extensions/tiptap-extensions/KeyboardShortcuts/KeyboardShortcutsExtension.ts

matthewlipski · 2026-02-24T10:26:55Z

How do you test the delete key on macOS? I'm unsure how to do it

I think it's Fn+Backspace but not 100% sure since I use a keyboard with Windows modifiers

# Conflicts: # tests/src/utils/const.ts

Added missing Delete key handlers

c6449f3

Removed debugger statements

9787e87

vercel bot deployed to Preview – blocknote October 23, 2025 14:50 View deployment

vercel bot deployed to Preview – blocknote-website October 23, 2025 14:52 View deployment

nperez0111 reviewed Oct 27, 2025

View reviewed changes

packages/core/src/extensions/tiptap-extensions/KeyboardShortcuts/KeyboardShortcutsExtension.ts Outdated Show resolved Hide resolved

nperez0111 requested changes Oct 29, 2025

View reviewed changes

Merge branch 'main' into delete-handler-imprevements

2bd3f4a

vercel bot deployed to Preview – blocknote February 20, 2026 12:34 View deployment

vercel bot deployed to Preview – blocknote-website February 20, 2026 12:36 View deployment

Added additional backspace/delete handlers

0cd1a63

vercel bot deployed to Preview – blocknote February 20, 2026 15:14 View deployment

vercel bot deployed to Preview – blocknote-website February 20, 2026 15:17 View deployment

Added additional case for delete handler

98c5f36

vercel bot deployed to Preview – blocknote-website February 20, 2026 16:51 View deployment

vercel bot deployed to Preview – blocknote February 20, 2026 16:52 View deployment

Added tests

cec561f

vercel bot deployed to Preview – blocknote February 23, 2026 21:01 View deployment

vercel bot deployed to Preview – blocknote-website February 23, 2026 21:03 View deployment

nperez0111 reviewed Feb 24, 2026

View reviewed changes

packages/core/src/api/blockManipulation/commands/mergeBlocks/mergeBlocks.ts Outdated Show resolved Hide resolved

nperez0111 reviewed Feb 24, 2026

View reviewed changes

packages/core/src/extensions/tiptap-extensions/KeyboardShortcuts/KeyboardShortcutsExtension.ts Outdated Show resolved Hide resolved

matthewlipski added 2 commits February 24, 2026 12:06

Implemented PR feedback

2eac48f

Merge branch 'main' into delete-handler-imprevements

9448f41

# Conflicts: # tests/src/utils/const.ts

vercel bot deployed to Preview – blocknote-website February 24, 2026 11:11 View deployment

vercel bot deployed to Preview – blocknote February 24, 2026 11:12 View deployment

Uh oh!

Comments

Conversation

matthewlipski commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Rationale

Changes

Impact

Testing

Screenshots/Video

Checklist

Additional Notes

Uh oh!

vercel bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nperez0111 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nperez0111 Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

matthewlipski Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

matthewlipski Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

nperez0111 Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

nperez0111 Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

matthewlipski Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

nperez0111 Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

nperez0111 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

matthewlipski commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

matthewlipski commented Oct 23, 2025 •

edited

Loading

vercel bot commented Oct 23, 2025 •

edited

Loading

pkg-pr-new bot commented Oct 23, 2025 •

edited

Loading