Skip to content

chore(skills): 🧹 drop the unreferenced skills-repo template copy - #1097

Merged
binggg merged 1 commit into
mainfrom
chore/drop-dead-skills-repo-template
Sep 24, 2026
Merged

binggg merged 1 commit into
mainfrom
chore/drop-dead-skills-repo-template

Conversation

@binggg

@binggg binggg commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

What

scripts/skills-repo-template/cloudbase-guidelines/** is an orphaned copy of the guideline skill.

It is not a byte-identical duplicate: 2 of its 7 files match the source, 5 have diverged (209 changed lines), it never picked up references/site-onboarding.md, and its version: 2.25.10 sits behind the source's 2.34.6.

It used to be the real thing, and a refactor orphaned it in place:

  • fb2370aac (2026-01-22) created it, and build-skills-repo.mjs read the guideline from that very path, publishing a skill directory named cloudbase-guidelines.
  • 0c2b82880 (2026-03-12, "migrate ai sources to minimal layout") switched that read to GUIDELINE_SOURCE_DIR = config/source/guideline/cloudbase.
  • 90d5bd49c (2026-07-28) renamed the published directory to cloudbase.

Nothing has read it since 2026-03-12, but it stayed tracked, was still hand-edited once afterwards (17b4b99a5, "align publish templates"), and kept reading as authoritative guidance while drifting nine minor versions behind.

Reference surfaces checked:

  • build-skills-repo.mjs publishes the guideline from config/source/guideline/cloudbase (GUIDELINE_SOURCE_DIR). The only file it loads out of that template directory is readme-template.md.
  • Recursive grep over .github/: the single hit is push-skills-repo.yaml:11, whose paths: filter names readme-template.md specifically, not the directory.
  • No workflow has a scripts/** glob — every entry names one file, and the removed path appears in none of them.
  • connectors/, plugin/, plugins/, config/, marketplace.json: no hits.
  • sync-skill-versions.mjs covers only config/source/skills/** and config/source/guideline/cloudbase/SKILL.md, which is why the copy's version line was free to rot.

This removes the copy (7 files; readme-template.md stays) along with the one remaining mention of the removed path in a committed marketplace record, so no tracked file points at it any more.

Not touched

A stale doc comment in scripts/build-allinone-skill.ts still says the bundled skill entry comes from the template directory, while the code reads config/source/guideline/cloudbase/SKILL.md. Left alone on purpose: that file is in the paths: filter of the all-in-one / registry publish workflows, so a comment-only edit there triggers a republish of unchanged content. Better fixed alongside the next real change to that script, or by giving those workflows a content-diff guard.

Verification

  • node scripts/build-skills-repo.mjs still publishes skills/cloudbase — 8 files, each byte-identical to config/source/guideline/cloudbase (diff -r --brief clean), version: 2.34.6, and no cloudbase-guidelines directory in the output. The publish path never touched the removed copy.
  • npx vitest run tests/single-skill-fallback-links.test.js — 7/7 pass, including the case that runs build-skills-repo.mjs and asserts on its output.
  • node scripts/check-internal-refs.mjs --base origin/main — clean.

The diff is deletions only, and the removed path matches no workflow paths: entry, so it triggers no publish.

`scripts/skills-repo-template/cloudbase-guidelines/**` was a second copy of the
guideline skill that nothing reads. `build-skills-repo.mjs` publishes the
guideline from `config/source/guideline/cloudbase` (`GUIDELINE_SOURCE_DIR`); the
only file it loads out of that template directory is `readme-template.md`, and
the `push-skills-repo` workflow's path filter names that one file specifically.
No build step, test or other workflow referenced the copy.

It was kept in step by hand and had drifted to `version: 2.25.10` while the
source is at `2.34.6`, so it also read as authoritative guidance while being
nine minor versions behind.

The one remaining mention of the removed path, in a committed marketplace
record, goes with it, so no tracked file points at it any more.

Verified: `node scripts/build-skills-repo.mjs` still publishes `skills/cloudbase`
as 8 files byte-identical to `config/source/guideline/cloudbase`, and
`tests/single-skill-fallback-links.test.js` passes 7/7.
@binggg
binggg force-pushed the chore/drop-dead-skills-repo-template branch from a2906f6 to 0ba59fa Compare September 24, 2026 12:35
@binggg
binggg merged commit 29fa707 into main Sep 24, 2026
8 checks passed
@binggg

binggg commented Sep 24, 2026

Copy link
Copy Markdown
Member Author

Correcting one line in the verification section above, now that this has landed.

"Deletions only, so it matches no workflow paths: filter and triggers no publish" was too strong. The paths: half is right — the removed path is in no filter — but two workflows on this repo have no paths: filter at all, so they fire on every push to main regardless:

  • Bump Expert Versions — ran on the merge and committed 44bae566, a patch bump for plugins/experts/miniprogram-clouddev-expert. That pack was changed by an earlier push and the bump was pending; the commit's files are all under plugins/experts/.
  • Publish MCP Package to pkg.pr.new (nightly-build.yaml) — ran on the merge, preview build only.

Full set of runs triggered by the merge commit: CodeQL (push on main), Bump Expert Versions, Internal Docs Guard, pkg.pr.new, Sync to CNB.

What the filter did gate is the part that matters here: none of Push Skills Repository, Sync CloudBase Plugin Skills, Publish to ClawHub/SkillHub, Sync Derived Branches or Push Plugin Repos ran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant