chore(skills): 🧹 drop the unreferenced skills-repo template copy - #1097
Merged
Merged
Conversation
`scripts/skills-repo-template/cloudbase-guidelines/**` was a second copy of the guideline skill that nothing reads. `build-skills-repo.mjs` publishes the guideline from `config/source/guideline/cloudbase` (`GUIDELINE_SOURCE_DIR`); the only file it loads out of that template directory is `readme-template.md`, and the `push-skills-repo` workflow's path filter names that one file specifically. No build step, test or other workflow referenced the copy. It was kept in step by hand and had drifted to `version: 2.25.10` while the source is at `2.34.6`, so it also read as authoritative guidance while being nine minor versions behind. The one remaining mention of the removed path, in a committed marketplace record, goes with it, so no tracked file points at it any more. Verified: `node scripts/build-skills-repo.mjs` still publishes `skills/cloudbase` as 8 files byte-identical to `config/source/guideline/cloudbase`, and `tests/single-skill-fallback-links.test.js` passes 7/7.
binggg
force-pushed
the
chore/drop-dead-skills-repo-template
branch
from
September 24, 2026 12:35
a2906f6 to
0ba59fa
Compare
Member
Author
|
Correcting one line in the verification section above, now that this has landed. "Deletions only, so it matches no workflow
Full set of runs triggered by the merge commit: CodeQL (push on main), Bump Expert Versions, Internal Docs Guard, pkg.pr.new, Sync to CNB. What the filter did gate is the part that matters here: none of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/skills-repo-template/cloudbase-guidelines/**is an orphaned copy of the guideline skill.It is not a byte-identical duplicate: 2 of its 7 files match the source, 5 have diverged (209 changed lines), it never picked up
references/site-onboarding.md, and itsversion: 2.25.10sits behind the source's2.34.6.It used to be the real thing, and a refactor orphaned it in place:
fb2370aac(2026-01-22) created it, andbuild-skills-repo.mjsread the guideline from that very path, publishing a skill directory namedcloudbase-guidelines.0c2b82880(2026-03-12, "migrate ai sources to minimal layout") switched that read toGUIDELINE_SOURCE_DIR=config/source/guideline/cloudbase.90d5bd49c(2026-07-28) renamed the published directory tocloudbase.Nothing has read it since 2026-03-12, but it stayed tracked, was still hand-edited once afterwards (
17b4b99a5, "align publish templates"), and kept reading as authoritative guidance while drifting nine minor versions behind.Reference surfaces checked:
build-skills-repo.mjspublishes the guideline fromconfig/source/guideline/cloudbase(GUIDELINE_SOURCE_DIR). The only file it loads out of that template directory isreadme-template.md..github/: the single hit ispush-skills-repo.yaml:11, whosepaths:filter namesreadme-template.mdspecifically, not the directory.scripts/**glob — every entry names one file, and the removed path appears in none of them.connectors/,plugin/,plugins/,config/,marketplace.json: no hits.sync-skill-versions.mjscovers onlyconfig/source/skills/**andconfig/source/guideline/cloudbase/SKILL.md, which is why the copy's version line was free to rot.This removes the copy (7 files;
readme-template.mdstays) along with the one remaining mention of the removed path in a committed marketplace record, so no tracked file points at it any more.Not touched
A stale doc comment in
scripts/build-allinone-skill.tsstill says the bundled skill entry comes from the template directory, while the code readsconfig/source/guideline/cloudbase/SKILL.md. Left alone on purpose: that file is in thepaths:filter of the all-in-one / registry publish workflows, so a comment-only edit there triggers a republish of unchanged content. Better fixed alongside the next real change to that script, or by giving those workflows a content-diff guard.Verification
node scripts/build-skills-repo.mjsstill publishesskills/cloudbase— 8 files, each byte-identical toconfig/source/guideline/cloudbase(diff -r --briefclean),version: 2.34.6, and nocloudbase-guidelinesdirectory in the output. The publish path never touched the removed copy.npx vitest run tests/single-skill-fallback-links.test.js— 7/7 pass, including the case that runsbuild-skills-repo.mjsand asserts on its output.node scripts/check-internal-refs.mjs --base origin/main— clean.The diff is deletions only, and the removed path matches no workflow
paths:entry, so it triggers no publish.