Repository navigation
fix(cloudrun): accept absolute targetPath outside MCP cwd - #1077
Merged
Merged
Conversation
Member
Author
ATO cfdcf61a status
|
Absolute project paths were falsely rejected when the MCP process cwd differed (e.g. ~/.codex vs the user project): a same-root prefix check rejected valid deploys. Absolute paths now pass through; relative paths still block ../ traversal. Co-authored-by: Cursor <cursoragent@cursor.com>
binggg
force-pushed
the
fix/cfdcf61a-cloudrun-absolute-path
branch
from
September 23, 2026 07:41
7e026b6 to
764986a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
targetPathis accepted as-is; relative paths still cannot escape CWD via../.~/.codex,~/.workbuddy) while deploy/download targets the user project absolute path — a same-root prefix check incorrectly rejected valid deploys.cloudrun-path-validation.test.ts(4 cases) and richerpathOutsideCwdi18n guidance.Test plan
vitest run src/tools/cloudrun-path-validation.test.ts— 4/4 passMade with Cursor