fix: AI Chat Go to Settings button does nothing on macOS 14+#1056
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
On the AI Chat panel's "AI Not Configured" empty state, clicking "Go to Settings..." does nothing.
Root cause
AIChatPanelView.noProviderState's action posted the legacy AppKit selectorshowSettingsWindow:viaNSApp.sendAction(Selector(("showSettingsWindow:")), to: nil, from: nil). This selector was the responder-chain entry point for the legacy "Preferences" responder pattern. macOS 13+ renamed Preferences to Settings, and the SwiftUISettings { ... }scene installsSelector(("showSettingsWindow:"))only when no other entry point is present. With TablePro's setup (where Settings is opened viaWindowOpener.openSettings(tab:)), this responder selector is never registered, so the call silently fails.TablePro's minimum target is macOS 14, so this code path has been broken across every shipped version that exposes the empty state.
Fix
Route through the project's canonical entry point:
WindowOpener.openSettings(tab:)writes the requested tab toselectedSettingsTab(whichSettingsView's@AppStoragereads back) and invokes the action wired up inWindowOpener.start(...)fromTableProApp.swift. Same path used bySyncStatusIndicatorand other settings entry points.Scope check
I grepped for all uses of the buggy pattern. Only one occurrence in the codebase:
No other entry points use the legacy selector pattern, so this PR is one file, one line.
CHANGELOG
Entry under
[Unreleased]->Fixed.Test plan