Create smaller ShmChannel for empty input in graph store mode#592
Merged
kmontemayor2-sc merged 3 commits intomainfrom Apr 22, 2026
Merged
Create smaller ShmChannel for empty input in graph store mode#592kmontemayor2-sc merged 3 commits intomainfrom
kmontemayor2-sc merged 3 commits intomainfrom
Conversation
Collaborator
Author
|
/all_test |
Contributor
GiGL Automation@ 21:31:13UTC : 🔄 @ 22:55:19UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 21:31:15UTC : 🔄 @ 22:52:11UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 21:31:15UTC : 🔄 @ 21:41:20UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 21:31:16UTC : 🔄 @ 22:30:55UTC : ❌ Workflow failed. |
Contributor
GiGL Automation@ 21:31:16UTC : 🔄 @ 21:39:02UTC : ✅ Workflow completed successfully. |
kmontemayor2-sc
requested review from
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Since we default to "CONTIGUOUS" now, many ranks will have inputs registered that are empty, so we should not allocated the full SHM channel for them.
Note we still need to register inputs for all ranks as the DistSampler is in charge of serving incoming RPC sampling requests.
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO