Page language URLs are not taken into account when clicking "Translate to all languages"

[ivangretsky]

... On my dev installation I have 3 languages configured in Fluency module config and 3 languages activated for the page where I do testing. But on the prod installation I have like 10 languages configured in Fluency and only 3 active on a testing page.

So when I test on prod Fluency somewhy tries to translate to all languages configured (not to all active on a page) - I can see the xhr requests. And tries to mark the tabs for those languages, which are missing. And here we get an error that I have sent a screenshot of above.

Could you please help to confirm and fix this one too 🙏

Originally posted by @ivangretsky in #21

Good day @SkyLundy !

If a site has 10 languages set, but only a few activated for a page (some languages urls unchecked on the page settings tab - see the screenshot below), "Translate to all languages" still produces 10 API requests, trying to translate to all languages configured for a SITE and not the current PAGE.

[SkyLundy]

@ivangretsky This is because when you click "Translate to all languages" it translates the title field to all languages. ProcessWire handles automatically inserting the title as a slug. So when you uncheck "Active?" ProcessWire won't create a separate slug, but translating the title continues to work as expected and fills in your Title field in all languages. This is working correctly.

[ivangretsky]

The screen was to show that there could be some languages turned off for a page. Not just about title field.

Say I have 10 languages on the site but only 2 turned on for a certain page. And then I click "translate all" on say a body field I expect Fluency to translate the body field to only those 2 languages. But now there are 10 API calls 8 of which are simply wasted.

[SkyLundy]

Got it.

From what I understand, unchecking 'Active?' doesn't turn off a language for a page, it only turns off the unique slug for that page in a language. I just confirmed this behavior in a PW instance.

After creating or saving a page with "Active?" unchecked, look at the settings tab. ProcessWire automatically fills in the slugs for each language with the default language slug.

In that image, I unchecked the "Active?" for the two languages, and ProcessWire automatically filled that in. The languages are not truly disabled for the page. This can be confirmed by visiting the URL for each language on the front end with different content present in a field.

Here's a title field with "Test" for the default language, and "Hello" for French.

Those values were manually entered, not translated, but the concept would remain the same even if I did use Fluency to translate.

In this demo template I have the title field output to the page title tag. Here it is in the default language (English) where it displays "Test".

Here it is in French, which has "Active?" next to the page slug unchecked. It displays "Hello"

"Active?" doesn't toggle a language in ProcessWire for a page, it just disables the unique slug and allows the page in both languages to use /test and /fr/test. Because ProcessWire doesn't truly disable a language when "Active?" is unchecked, neither will Fluency. The module matches the behavior of ProcessWire.

In your other GH issue I showed how to filter languages which will prevent Fluency from adding translation for them in the admin when editing a page. Applying that in a hook will get you the behavior desired.

[ivangretsky]

Thanks for the detailed answer. Let me recheck everything and then come back and probably close the issue.