Is matchPatternAtPosition not good?

[RonYanDaik]

Code says:

// IMPORTANT TODO !!!!
// This matching algorithm seems garbo
bool Grid::matchPatternAtPosition(const Rule & aRule, math::Position<3, int> aPosition)

I don't understand why. Could you elaborate?

[FranzPoize]

Not sure if it's not good but it seems like a pretty naive approach. You should look into matrix pattern matching and try to find out because I apparently did not do so :D

Found this https://www.geeksforgeeks.org/rabin-karp-algorithm-for-pattern-searching-in-matrix/ by looking for 10 sec that present a different algorithm. Is it better ? I don't know.

This comment is especially true for this use

MarkovJunior.cpp/src/libs/markovjunior/markovjunior/RuleNode.cpp

Line 239 in 846b7d2

if (grid.matchPatternAtPosition(rule, matchPos))