fix: load materializations before destroy snapshot reads

Signed-off-by: lafirm <136463254+lafirm@users.noreply.github.com>

Author: lafirm

sqlmesh/core/context.py

@@ -1019,6 +1019,10 @@ def run_janitor(
 
     @python_api_analytics
     def destroy(self) -> bool:
+        # Load first so snapshot unpickling cannot import a custom-kind module that this load then reimports.
+        # If loading fails, abort before invalidating any environments.
+        self._load_materializations()
+
         success = False
 
         # Collect resources to be deleted
@@ -3158,9 +3162,6 @@ def _context_diff(
         )
 
     def _destroy(self) -> bool:
-        # Load materializations before any state writes so a failure aborts destroy without invalidating environments
-        self._load_materializations()
-
         # Invalidate all environments, including prod
         for environment in self.state_reader.get_environments():
             self.state_sync.invalidate_environment(name=environment.name, protect_prod=False)

tests/core/integration/test_aux_commands.py

@@ -125,7 +125,7 @@ def test_destroy_fails_before_invalidating_environments_on_materialization_error
     context._materializations_loaded = False
 
     with pytest.raises(SQLMeshError, match="broken materialization"):
-        context._destroy()
+        context.destroy()
 
     assert context.state_reader.get_environment("prod").expiration_ts is None