Skip to content

Commit ebc4dd7

Browse files
chore: set temporality delta for all types of metrics
1 parent 7c63840 commit ebc4dd7

2 files changed

Lines changed: 23 additions & 4 deletions

File tree

‎src/sap_cloud_sdk/core/telemetry/_provider.py‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from opentelemetry import metrics
77
from opentelemetry.exporter.otlp.proto.grpc.metric_exporter import OTLPMetricExporter
8-
from opentelemetry.sdk.metrics import MeterProvider, Counter
8+
from opentelemetry.sdk.metrics import MeterProvider, Counter, Histogram, ObservableCounter, ObservableGauge, ObservableUpDownCounter, UpDownCounter
99
from opentelemetry.sdk.metrics.export import (
1010
AggregationTemporality,
1111
PeriodicExportingMetricReader,
@@ -80,6 +80,11 @@ def _setup_meter_provider() -> Optional[MeterProvider]:
8080
endpoint=config.otlp_endpoint,
8181
preferred_temporality={
8282
Counter: AggregationTemporality.DELTA,
83+
Histogram: AggregationTemporality.DELTA,
84+
ObservableCounter: AggregationTemporality.DELTA,
85+
ObservableGauge: AggregationTemporality.DELTA,
86+
ObservableUpDownCounter: AggregationTemporality.DELTA,
87+
UpDownCounter: AggregationTemporality.DELTA,
8388
},
8489
)
8590

‎tests/core/unit/telemetry/test_provider.py‎

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import pytest
44
from unittest.mock import patch, MagicMock
55

6-
from opentelemetry.sdk.metrics import Counter
6+
from opentelemetry.sdk.metrics import Counter, Histogram, ObservableCounter, ObservableGauge, ObservableUpDownCounter, UpDownCounter
77
from opentelemetry.sdk.metrics.export import AggregationTemporality
88

99
from sap_cloud_sdk.core.telemetry._provider import (
@@ -188,7 +188,14 @@ def test_setup_meter_provider_success(self):
188188
# Verify exporter was created with endpoint and delta temporality
189189
mock_exporter_class.assert_called_once_with(
190190
endpoint="http://localhost:4317",
191-
preferred_temporality={Counter: AggregationTemporality.DELTA},
191+
preferred_temporality={
192+
Counter: AggregationTemporality.DELTA,
193+
Histogram: AggregationTemporality.DELTA,
194+
ObservableCounter: AggregationTemporality.DELTA,
195+
ObservableGauge: AggregationTemporality.DELTA,
196+
ObservableUpDownCounter: AggregationTemporality.DELTA,
197+
UpDownCounter: AggregationTemporality.DELTA,
198+
},
192199
)
193200

194201
# Verify reader was created with exporter
@@ -231,5 +238,12 @@ def test_setup_meter_provider_with_valid_config(self):
231238
# Verify exporter was created with correct endpoint and delta temporality
232239
mock_exporter.assert_called_with(
233240
endpoint=config.otlp_endpoint,
234-
preferred_temporality={Counter: AggregationTemporality.DELTA},
241+
preferred_temporality={
242+
Counter: AggregationTemporality.DELTA,
243+
Histogram: AggregationTemporality.DELTA,
244+
ObservableCounter: AggregationTemporality.DELTA,
245+
ObservableGauge: AggregationTemporality.DELTA,
246+
ObservableUpDownCounter: AggregationTemporality.DELTA,
247+
UpDownCounter: AggregationTemporality.DELTA,
248+
},
235249
)

0 commit comments

Comments
 (0)