Address code review comments

Author: simeongelovski

Makefile

@@ -0,0 +1,21 @@
+# Proto code generation for SAP Cloud SDK for Python
+# Requires: buf CLI (https://buf.build/docs/installation)
+
+AUDITLOG_NG_DIR := src/sap_cloud_sdk/core/auditlog_ng
+GEN_DIR         := $(AUDITLOG_NG_DIR)/gen
+BUF_DIR         := src/buf
+
+.PHONY: proto
+
+proto:
+# Generate code using buf CLI
+	cd $(AUDITLOG_NG_DIR) && buf dep update && buf generate --include-imports
+
+# Add __init__.py files to generated code
+    find $(GEN_DIR) -type d -exec touch {}/__init__.py \;
+
+# Move /buf generated code to the root
+	rm -rf $(BUF_DIR);
+	mv $(GEN_DIR)/buf $(BUF_DIR);
+	rm -rf $(GEN_DIR)/buf;
+

src/sap_cloud_sdk/core/auditlog_ng/__init__.py

@@ -29,7 +29,6 @@
 from sap_cloud_sdk.core.auditlog_ng.config import (
     AuditLogNGConfig,
     SCHEMA_URL,
-    validate_source_arg,
 )
 from sap_cloud_sdk.core.auditlog_ng.exceptions import (
     AuditLogNGError,
@@ -38,6 +37,8 @@
     ValidationError,
 )
 
+from sap_cloud_sdk.core.telemetry import Module
+
 
 def create_client(
     *,
@@ -53,6 +54,7 @@ def create_client(
     batch: bool = False,
     compression: bool = True,
     schema_url: str = SCHEMA_URL,
+    _telemetry_source: Optional[Module] = None
 ) -> AuditClient:
     """Create an AuditClient for sending audit events over OTLP/gRPC.
 
@@ -102,7 +104,7 @@ def create_client(
                 schema_url=schema_url,
             )
 
-        return AuditClient(config)
+        return AuditClient(config, _telemetry_source=_telemetry_source)
 
     except (ValueError, ValidationError) as e:
         raise e
@@ -117,7 +119,6 @@ def create_client(
     "AuditClient",
     # Configuration
     "AuditLogNGConfig",
-    "SCHEMA_URL",
     # Exceptions
     "AuditLogNGError",
     "ClientCreationError",

src/sap_cloud_sdk/core/auditlog_ng/buf.gen.yaml

@@ -0,0 +1,9 @@
+version: v2
+clean: true
+plugins:
+  - remote: buf.build/protocolbuffers/python:v33.5
+    out: gen
+    include_imports: true
+  - remote: buf.build/protocolbuffers/pyi:v33.5
+    out: gen
+    include_imports: true

src/sap_cloud_sdk/core/auditlog_ng/buf.yaml

@@ -0,0 +1,5 @@
+version: v2
+modules:
+  - path: proto
+deps:
+  - buf.build/bufbuild/protovalidate

src/sap_cloud_sdk/core/auditlog_ng/client.py

@@ -134,6 +134,10 @@ def send(
             RuntimeError: If the client has already been closed.
             ValueError: If *format* is not a supported value.
             ValidationError: If the protobuf event fails validation.
+
+        Note:
+            A successful return does not guarantee delivery.
+            The OTLP exporter operates asynchronously. Always use flush() before shutdown to maximize delivery probability.
         """
         if self._closed:
             raise RuntimeError("Client is closed")

src/sap_cloud_sdk/core/auditlog_ng/exceptions.py

@@ -13,12 +13,6 @@ class ClientCreationError(AuditLogNGError):
     pass
 
 
-class TransportError(AuditLogNGError):
-    """Raised when gRPC transport operations fail."""
-
-    pass
-
-
 class ValidationError(AuditLogNGError):
     """Raised when audit event validation fails."""
 

src/sap_cloud_sdk/core/auditlog_ng/proto/protoc/gen/jsonschema/v1/options.proto

@@ -0,0 +1,32 @@
+// Custom options for protoc-gen-jsonschema
+// Allocated range is 1125-1129
+// See https://github.com/protocolbuffers/protobuf/blob/master/docs/options.md
+
+syntax = "proto3";
+package protoc.gen.jsonschema.v1;
+
+import "google/protobuf/descriptor.proto";
+
+option go_package = "github.com/chrusty/protoc-gen-jsonschema";
+
+// Custom FieldOptions
+message FieldOptions {
+  // Fields tagged with this will be omitted from generated schemas
+  bool ignore = 1;
+
+  // Fields tagged with this will be marked as "required" in generated schemas
+  bool required = 2;
+
+  // Fields tagged with this will constrain strings using the "minLength" keyword in generated schemas
+  int32 min_length = 3;
+
+  // Fields tagged with this will constrain strings using the "maxLength" keyword in generated schemas
+  int32 max_length = 4;
+
+  // Fields tagged with this will constrain strings using the "pattern" keyword in generated schemas
+  string pattern = 5;
+}
+
+extend google.protobuf.FieldOptions {
+  FieldOptions field_options = 1125;
+}