Skip to content

Commit 5adcc72

Browse files
committed
fix(auditlog-ng): fix test patches for _create_log_exporter and bump version
Tests were patching the removed OTLPLogExporter attribute; update to patch _create_log_exporter instead. Bump version to 0.12.1 as required by CI.
1 parent 84b2392 commit 5adcc72

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

‎pyproject.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[project]
22
name = "sap-cloud-sdk"
3-
version = "0.12.0"
3+
version = "0.12.1"
44
description = "SAP Cloud SDK for Python"
55
readme = "README.md"
66
license = "Apache-2.0"

‎tests/core/unit/auditlog_ng/unit/test_create_client.py‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010

1111
class TestCreateClient:
1212

13-
@patch("sap_cloud_sdk.core.auditlog_ng.client.OTLPLogExporter")
13+
@patch("sap_cloud_sdk.core.auditlog_ng.client._create_log_exporter")
1414
@patch("sap_cloud_sdk.core.auditlog_ng.client.LoggerProvider")
15-
def test_create_client_with_config(self, mock_provider_cls, mock_exporter_cls):
15+
def test_create_client_with_config(self, mock_provider_cls, mock_exporter_fn):
1616
mock_provider = Mock()
1717
mock_provider.get_logger.return_value = Mock()
1818
mock_provider_cls.return_value = mock_provider
@@ -28,9 +28,9 @@ def test_create_client_with_config(self, mock_provider_cls, mock_exporter_cls):
2828

2929
assert isinstance(client, AuditClient)
3030

31-
@patch("sap_cloud_sdk.core.auditlog_ng.client.OTLPLogExporter")
31+
@patch("sap_cloud_sdk.core.auditlog_ng.client._create_log_exporter")
3232
@patch("sap_cloud_sdk.core.auditlog_ng.client.LoggerProvider")
33-
def test_create_client_with_keyword_args(self, mock_provider_cls, mock_exporter_cls):
33+
def test_create_client_with_keyword_args(self, mock_provider_cls, mock_exporter_fn):
3434
mock_provider = Mock()
3535
mock_provider.get_logger.return_value = Mock()
3636
mock_provider_cls.return_value = mock_provider
@@ -68,10 +68,10 @@ def test_create_client_invalid_deployment_id_raises(self):
6868
namespace="ns-1",
6969
)
7070

71-
@patch("sap_cloud_sdk.core.auditlog_ng.client.OTLPLogExporter")
71+
@patch("sap_cloud_sdk.core.auditlog_ng.client._create_log_exporter")
7272
@patch("sap_cloud_sdk.core.auditlog_ng.client.LoggerProvider")
7373
def test_create_client_unexpected_exception_wraps_in_client_creation_error(
74-
self, mock_provider_cls, mock_exporter_cls
74+
self, mock_provider_cls, mock_exporter_fn
7575
):
7676
mock_provider_cls.side_effect = RuntimeError("Unexpected failure")
7777

@@ -83,9 +83,9 @@ def test_create_client_unexpected_exception_wraps_in_client_creation_error(
8383
insecure=True,
8484
)
8585

86-
@patch("sap_cloud_sdk.core.auditlog_ng.client.OTLPLogExporter")
86+
@patch("sap_cloud_sdk.core.auditlog_ng.client._create_log_exporter")
8787
@patch("sap_cloud_sdk.core.auditlog_ng.client.LoggerProvider")
88-
def test_config_keyword_args_are_forwarded(self, mock_provider_cls, mock_exporter_cls):
88+
def test_config_keyword_args_are_forwarded(self, mock_provider_cls, mock_exporter_fn):
8989
mock_provider = Mock()
9090
mock_provider.get_logger.return_value = Mock()
9191
mock_provider_cls.return_value = mock_provider

‎uv.lock‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)