diff --git a/arbalister/adbc.py b/arbalister/adbc.py index dd71599..2e0b546 100644 --- a/arbalister/adbc.py +++ b/arbalister/adbc.py @@ -87,9 +87,14 @@ def to_arrow_table(self) -> pa.Table: if self._limit is not None and self._offset is not None else "" ) - columns = self._select if self._select is not None else ["*"] + + # Escape column names or default to wildcard + if self._select is not None: + columns = ",".join(f'"{c}"' for c in self._select) + else: + columns = "*" with adbc_sqlite.connect(self._path) as connection: with connection.cursor() as cursor: - cursor.execute(f'SELECT {",".join(columns)} FROM "{self._table_name}" {limit}') + cursor.execute(f'SELECT {columns} FROM "{self._table_name}" {limit}') return cursor.fetch_arrow_table() diff --git a/arbalister/params.py b/arbalister/params.py index 9696490..e734f7b 100644 --- a/arbalister/params.py +++ b/arbalister/params.py @@ -97,7 +97,7 @@ def _parse_value(value: Any, annotation: Any) -> Any: def build_dataclass[T](dataclass_type: type[T], callback: Callable[[str, Any], Any]) -> T: - """Build a dtaclass from its definition and a value-p[rovising callback.""" + """Build a dataclass from its definition and a value-provising callback.""" values: dict[str, Any] = {} for field in dataclasses.fields(cast(type[Any], dataclass_type)): default = ( diff --git a/arbalister/tests/test_routes.py b/arbalister/tests/test_routes.py index 43fcc20..5d96a12 100644 --- a/arbalister/tests/test_routes.py +++ b/arbalister/tests/test_routes.py @@ -71,10 +71,10 @@ def dummy_table_1(num_rows: int = 10) -> pa.Table: def dummy_table_2(num_rows: int = 13) -> pa.Table: """Generate a table with different fake data.""" data = { - "id": list(range(num_rows)), - "flag": [random.choice([True, False]) for _ in range(num_rows)], - "letter": random.choices(string.ascii_letters, k=num_rows), - "score": [random.randint(0, 100) for _ in range(num_rows)], + "__id": list(range(num_rows)), + "Flag": [random.choice([True, False]) for _ in range(num_rows)], + "ASCII letter": random.choices(string.ascii_letters, k=num_rows), + "score 🏆": [random.randint(0, 100) for _ in range(num_rows)], "timestamp": [random.randint(1_600_000_000, 1_700_000_000) for _ in range(num_rows)], } table = pa.table(data)