Skip to content

Commit bf25db3

Browse files
author
Amperstrand
committed
docs(changelog): move the SSID-format contract entry to [Unreleased]
The wave-3 catch: the entry sat inside the frozen [v0.6.0-alpha4] section (the tag exists); new entries belong in [Unreleased].
1 parent 748a05e commit bf25db3

1 file changed

Lines changed: 16 additions & 2 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,22 @@ and [Semantic Versioning](https://semver.org/).
199199
when a future pin stops sending the MAC or drops those strings
200200
([#536](https://github.com/OpenTollGate/tollgate-module-basic-go/pull/536)).
201201

202-
### Changed / Internal
203-
202+
- **The open-AP SSID format is now a checked contract.** `99-tollgate-setup`
203+
names the access point `<brand>-<4 hex characters>` (`TollGate-A1B2` for
204+
the default brand) and puts that same name on both radios, so
205+
`tests/contract/check-ssid-format.sh` — a CI gate, also wired into
206+
`hooks/pre-commit` — now fails when that stops being true. It sources the
207+
real `setup_public_wifi()` out of the script, runs it against a stub `uci`
208+
and asserts the SSID it actually writes: both radios matching
209+
`^TollGate-[0-9A-F]{4}$` for the default brand, one shared name, a
210+
per-device 4-hex suffix. A second, structural layer checks the assignment
211+
sites a checkout cannot execute — the same-version reinstall path recovers
212+
its SSID from live config, and the whitelabel branch reads
213+
`/etc/tollgate/brand` — so neither branch can quietly acquire a band
214+
suffix. That suffix is the drift the test exists for: the Go side keys on
215+
the `TollGate-` prefix (`discovery_log.go`, `vendor_element_manager.go`),
216+
and `TollGate-A1B2-2.4GHz` would be a second network identity for the same
217+
router.
204218
- **`getMacAddress`'s two lookup sources are package-level vars, so
205219
`/balance`'s session-bearing branch has unit coverage again.** The DHCP-lease
206220
and ARP paths were string literals, so off-router every `/balance` test landed

0 commit comments

Comments
 (0)